From: Miles Bader <miles@gnu.org>
Subject: Re: suggested feature -- console-mode frame title sets Xterm title
Date: 02 Oct 2003 23:58:55 +0900 [thread overview]
Message-ID: <87he2rd6ts.fsf@tc-1-100.kawasaki.gol.ne.jp> (raw)
In-Reply-To: 20031002085212.GA1259@sourcefrog.net
Martin Pool <mbp@sourcefrog.net> writes:
> Do you have any comments on the patch? This is my first patch for
> emacs internals, so please don't trust me. :-)
It's a little hard to evaluate in isolation, but here are a few comments:
> diff -dru emacs-21.3/lisp/cus-start.el emacs-21.3-title/lisp/cus-start.el
> + (tty-frame-use-title display boolean)
> + (tty-frame-title-start display string)
> + (tty-frame-title-end display end)
Why are the latter two variables being added to the customize framework?
They seem like low-level variables that are only exported to lisp for
the terminal lisp files to use, not something that a user would
customize.
> diff -dru emacs-21.3/lisp/term/xterm.el emacs-21.3-title/lisp/term/xterm.el
> +(set-variable 'tty-frame-title-start "\e]2;")
> +(set-variable 'tty-frame-title-end "\007")
Why use `set-variable' instead of `set', or indeed, instead of just `setq'?
> diff -dru emacs-21.3/src/dispextern.h emacs-21.3-title/src/dispextern.h
> void
> +terminal_set_frame_title (line, len)
term.c is not particularly consistent, but in general the naming
convention used seems to be either `set_terminal_foo' or `set_tty_foo'.
> diff -dru emacs-21.3/src/xdisp.c emacs-21.3-title/src/xdisp.c
> + DEFVAR_BOOL ("tty-frame-use-title", &tty_frame_use_title,
> +"*Show frame titles in the title or status line of text terminals.\n\
I find the name `tty-frame-use-title' a bit odd; how about something
like `tty-show-frame-titles' (it's the first three words of the
docstring, which must mean something :-)?
-Miles
--
A zen-buddhist walked into a pizza shop and
said, "Make me one with everything."
next prev parent reply other threads:[~2003-10-02 14:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-14 16:49 suggested feature -- console-mode frame title sets Xterm title Eric Hanchrow
2002-06-15 21:47 ` Richard Stallman
2003-09-26 5:04 ` Martin Pool
2003-09-27 2:32 ` Richard Stallman
2003-09-29 5:17 ` Martin Pool
2003-10-01 21:21 ` Richard Stallman
2003-10-01 21:45 ` Martin Pool
2003-10-02 6:34 ` Martin Pool
2003-10-02 7:00 ` Miles Bader
2003-10-02 8:52 ` Martin Pool
2003-10-02 14:58 ` Miles Bader [this message]
2003-10-02 19:15 ` Richard Stallman
2003-10-03 5:58 ` Martin Pool
[not found] ` <E1A58vH-0002KC-Mq@fencepost.gnu.org>
2003-10-03 1:04 ` Martin Pool
[not found] ` <E1A5p16-0001Wq-3Y@fencepost.gnu.org>
2003-10-14 3:59 ` Martin Pool
2003-10-14 6:39 ` Eli Zaretskii
2003-10-14 7:15 ` Martin Pool
2003-10-14 7:29 ` Miles Bader
2003-10-14 7:44 ` Martin Pool
2003-10-14 7:56 ` Miles Bader
2003-10-14 8:01 ` Martin Pool
2003-10-15 6:01 ` Eli Zaretskii
2003-10-14 9:10 ` Eli Zaretskii
2003-10-14 9:40 ` Romain FRANCOISE
2003-10-14 9:07 ` Eli Zaretskii
2003-10-15 4:08 ` Richard Stallman
2003-10-15 6:07 ` Eli Zaretskii
2003-10-15 6:22 ` Miles Bader
2003-10-15 6:36 ` Martin Pool
2003-10-16 14:06 ` Richard Stallman
2003-10-16 14:06 ` Richard Stallman
2003-10-14 19:32 ` Richard Stallman
2003-10-15 2:47 ` Martin Pool
2003-10-15 20:00 ` Richard Stallman
2003-10-16 7:32 ` Eli Zaretskii
2003-10-16 8:25 ` Miles Bader
2003-10-16 8:35 ` Martin Pool
2003-10-16 9:07 ` Miles Bader
2003-10-16 17:04 ` Stefan Monnier
2003-10-16 23:07 ` Richard Stallman
2003-10-30 3:03 ` Martin Pool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87he2rd6ts.fsf@tc-1-100.kawasaki.gol.ne.jp \
--to=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.