Today's :ignore-defface changes: Emacs segfaults immediately

Today's :ignore-defface changes: Emacs segfaults immediately

[Romain Francoise]

After this change:

2005-11-20  Chong Yidong  <cyd@stupidchicken.com>

	* xfaces.c (Finternal_set_lisp_face_attribute): Use
	:ignore-defface for new frame defaults when `unspecified' is
	supplied.
	(Finternal_get_lisp_face_attribute): Hide :ignore-defface.

Emacs segfaults immediately after startup.  It seems to be working fine
with `emacs -q', but not with my config file.  Reverting this change
makes things work again.

#0  0xffffe410 in __kernel_vsyscall ()
#1  0xa776dad6 in kill () from /lib/tls/i686/cmov/libc.so.6
#2  0x080f1fc9 in fatal_error_signal (sig=11) at emacs.c:427
#3  <signal handler called>
#4  init_iterator (it=0xafd65d04, w=0x85c1148, charpos=-1, bytepos=-1, 
    row=0x8cc2e04, base_face_id=MODE_LINE_FACE_ID) at xdisp.c:2646
#5  0x080788d7 in display_mode_line (w=Variable "w" is not available.
) at xdisp.c:16164
#6  0x08078bba in display_mode_lines (w=0x85c1148) at xdisp.c:16131
#7  0x08079d7c in redisplay_window (window=140251468, just_this_one_p=0)
    at xdisp.c:12973
#8  0x0807c063 in redisplay_window_0 (window=140251468) at xdisp.c:11404
#9  0x081581d2 in internal_condition_case_1 (
    bfun=0x807c040 <redisplay_window_0>, arg=140251468, handlers=137500909, 
    hfun=0x8070f80 <redisplay_window_error>) at eval.c:1506
#10 0x08070d32 in redisplay_windows (window=Variable "window" is not available.
) at xdisp.c:11383
#11 0x0807d7df in redisplay_internal (preserve_echo_area=Variable "preserve_echo_area" is not available.
) at xdisp.c:10943
#12 0x080fd6a5 in read_char (commandflag=1, nmaps=3, maps=0xafd66c70, 
    prev_event=137513977, used_mouse_menu=0xafd66d18) at keyboard.c:2535
#13 0x080ffa0c in read_key_sequence (keybuf=0xafd66db4, bufsize=30, 
    prompt=137513977, dont_downcase_last=0, can_return_switch_frame=1, 
    fix_current_buffer=1) at keyboard.c:8840
#14 0x081015ef in command_loop_1 () at keyboard.c:1523
#15 0x081584db in internal_condition_case (bfun=0x8101450 <command_loop_1>, 
    handlers=137557761, hfun=0x80f9aa0 <cmd_error>) at eval.c:1465
#16 0x080f3f26 in command_loop_2 () at keyboard.c:1315
#17 0x081583ec in internal_catch (tag=0, func=0x80f3f00 <command_loop_2>, 
    arg=137513977) at eval.c:1211
#18 0x080f3d17 in command_loop () at keyboard.c:1294
#19 0x080f3db0 in recursive_edit_1 () at keyboard.c:987
#20 0x080f3eba in Frecursive_edit () at keyboard.c:1048
#21 0x080f2f4c in main (argc=1, argv=0xafd67424) at emacs.c:1780

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: Today's :ignore-defface changes: Emacs segfaults immediately

[Chong Yidong]

Romain Francoise <romain@orebokech.com> writes:

> After this change:
>
> 2005-11-20  Chong Yidong  <cyd@stupidchicken.com>
>
> 	* xfaces.c (Finternal_set_lisp_face_attribute): Use
> 	:ignore-defface for new frame defaults when `unspecified' 
          is
> 	supplied.
> 	(Finternal_get_lisp_face_attribute): Hide :ignore-defface.
>
> Emacs segfaults immediately after startup.  It seems to be 
  working fine
> with `emacs -q', but not with my config file.  Reverting this 
  change
> makes things work again.

Could you find the part of the config file that makes it segfault?

Re: Today's :ignore-defface changes: Emacs segfaults immediately

[Romain Francoise]

Chong Yidong <cyd@stupidchicken.com> writes:

> Could you find the part of the config file that makes it segfault?

Sure; it segfaults when calling the `color-theme-dark-laptop' function,
from the color-theme.el package.  Reducing the init file to just this
function shows this additional message before the segfault:

Wrong type argument: bitmap-spec-p, unspecified

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter

Re: Today's :ignore-defface changes: Emacs segfaults immediately

[Chong Yidong]

Romain Francoise <romain@orebokech.com> writes:

>> Could you find the part of the config file that makes it segfault?
>
> Sure; it segfaults when calling the `color-theme-dark-laptop' function,
> from the color-theme.el package.  Reducing the init file to just this
> function shows this additional message before the segfault:
>
> Wrong type argument: bitmap-spec-p, unspecified

I've checked in a fix.  Could you check if it's OK now?

Re: Today's :ignore-defface changes: Emacs segfaults immediately

[Romain Francoise]

Chong Yidong <cyd@stupidchicken.com> writes:

> I've checked in a fix.  Could you check if it's OK now?

It is, thanks,

-- 
Romain Francoise <romain@orebokech.com> | The sea! the sea! the open
it's a miracle -- http://orebokech.com/ | sea! The blue, the fresh, the
                                        | ever free! --Bryan W. Procter