From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael@cadilhac.name (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: ad-remove-advice bug. Date: Thu, 08 Mar 2007 19:07:33 +0100 Organization: Epita/LRDE Message-ID: <87hcsv7gnu.fsf@lrde.org> References: <878xe9t916.fsf@lrde.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1667057393==" X-Trace: sea.gmane.org 1173377296 22038 80.91.229.12 (8 Mar 2007 18:08:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 8 Mar 2007 18:08:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 08 19:08:03 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HPN22-0000N3-9L for ged-emacs-devel@m.gmane.org; Thu, 08 Mar 2007 19:08:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HPN2F-0005wT-Rl for ged-emacs-devel@m.gmane.org; Thu, 08 Mar 2007 13:08:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HPN20-0005tZ-6H for emacs-devel@gnu.org; Thu, 08 Mar 2007 13:08:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HPN1z-0005ps-7l for emacs-devel@gnu.org; Thu, 08 Mar 2007 13:07:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HPN1z-0005pV-34 for emacs-devel@gnu.org; Thu, 08 Mar 2007 13:07:59 -0500 Original-Received: from smtp3-g19.free.fr ([212.27.42.29]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HPN1h-00022A-1m; Thu, 08 Mar 2007 13:07:41 -0500 Original-Received: from localhost (ivr94-6-82-230-255-91.fbx.proxad.net [82.230.255.91]) by smtp3-g19.free.fr (Postfix) with ESMTP id E06DC85A2; Thu, 8 Mar 2007 19:07:38 +0100 (CET) X-Website: http://michael.cadilhac.name Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEU/JREXDATg1LV8UCao i1fQpmoP3Nd6AAACa0lEQVQ4jWWUQW7jMAxFqZEPICJzAjXeM6W8dyNqX9ji/a8yn04xnWIEJLD9 LJH85DcJFyJV3erqPty8ExHfBikXSdn0WVezC0hOAQiA2nCsAHOqEnPe4k+puU8zw/t+xquqjRKA 4lHsmQBT8C5pDtBwfwH8VdcHI5+FHtjRxrQRwZsf3hNjZRKAPEzHEdH9mFNSYb5dQK3r8KM6ftNy KikAirDZFWdVkDqbxjGFbAcwbQCxxc8mPRHUGOcCIMgMACV23RfJTch3gC6ofT3qCdG0NyUUPfYF yQrKCIAnuYsgX2qPzW2i9sNrfSOSPPZQiygtCNlCjlpXJV38lIKshF/AZzsAMoArdCKNHfXukPuJ ImbLh+9J2gXwap0QpZ7NjZ7ekdkFcDiqPiLGcHmuvaG/AHgy62s52Lae1ABoA7D6d2kDoAvgbnyD ZutEd6lTHOXfYPHVJDH1K8a1+oyrjoZpAGn1x5pfwPr2E9yjxSpk50/gEyKgD/+BD/KzN3tQ13b8 Cx5loF0AgnZf5IUny9hRHQOYBllHDM+6s3oviZBu77mFjDm621Np3hkjR90wE1BkTYvhdDgDgCmR xWChFfcYAOqMm5NZkVWMur8AL5+oeMQOob2FmY76FiM+PrDDZypwGdqokSlAaQOmGH6mW8KpsOwl 0YOLedjSITr6scNRF8D4PesH33QmLrx8AzjpV/3kkg025w2gfAFYKCLluJAc4Ap+h18oo4S8wzaY klDsBUTiY8EZFkg5Iass75FubC9wd8qa0u9+gRxAsAKEaRAo6iB+vwCMGmdBjvgidQGA1ntMX4CS ZYGV/wADyL80LIX/UAAAAABJRU5ErkJggg== In-Reply-To: (Richard Stallman's message of "Thu\, 08 Mar 2007 12\:40\:36 -0500") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67578 Archived-At: --===============1667057393== Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Richard Stallman writes: > Now, use M-x ad-remove-advice RET RET RET RET (the default each time) > There's two annoying things : > 1. M-x describe-function RET forward-line RET says : > | This subr is advised. > > That's not a bug; we need not do anything now. > > Your patch looks maybe ok for the future, but let's not do anything > there now. OK, so we'll see later. > 2. M-x ad-remove-advice default values are impossible. > > I do not understand. After the first call to `ad-remove-advice', the second call defaults its arguments to `forward-line' which has no more advices. Maybe we just want the following: --=-=-= Content-Type: text/x-patch; charset=iso-8859-1 Content-Disposition: inline; filename=advice.patch Content-Transfer-Encoding: quoted-printable Index: lisp/emacs-lisp/advice.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/emacs-lisp/advice.el,v retrieving revision 1.49 diff -B -w -c -r1.49 advice.el *** lisp/emacs-lisp/advice.el 21 Jan 2007 02:44:24 -0000 1.49 =2D-- lisp/emacs-lisp/advice.el 8 Mar 2007 18:04:43 -0000 *************** *** 2278,2284 **** "Read a complete function/class/name specification from minibuffer. The list of read symbols will be returned. The optional PROMPT will be used to prompt for the function." ! (let* ((function (ad-read-advised-function prompt)) (class (ad-read-advice-class function)) (name (ad-read-advice-name function class))) (list function class name))) =2D-- 2278,2288 ---- "Read a complete function/class/name specification from minibuffer. The list of read symbols will be returned. The optional PROMPT will be used to prompt for the function." ! (let* ((predicate (lambda (fun) ! (ad-dolist (class ad-advice-classes) ! (if (ad-get-advice-info-field fun class) ! (ad-do-return t))))) ! (function (ad-read-advised-function prompt predicate)) (class (ad-read-advice-class function)) (name (ad-read-advice-name function class))) (list function class name))) Index: lisp/ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.10783 diff -C0 -r1.10783 ChangeLog *** lisp/ChangeLog 7 Mar 2007 12:50:23 -0000 1.10783 =2D-- lisp/ChangeLog 8 Mar 2007 18:05:05 -0000 *************** *** 0 **** =2D-- 1,6 ---- + 2007-03-08 Micha=EBl Cadilhac +=20 + * emacs-lisp/advice.el (ad-read-advice-specification): Check that the + default value taken by `ad-read-advised-function' has non-empty + classes. +=20 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable =2D-=20 | Micha=EBl `Micha' Cadilhac | ... KVim is cited in the talk. = | | http://michael.cadilhac.name | "I can't tell if I am more sorry = | | JID/MSN: | for vim or for KDE." = | `---- michael.cadilhac@gmail.com | -- RMS - = --' --=-=-=-- --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.2 (GNU/Linux) iD8DBQFF8FDoUJhDmOfFA3URAqbJAJ4lA6u8rJ0d8+6Ab0ywX0mJFeFyngCg1Wjj joYmztzUJ8xXJe05lL4xMpY= =ntmM -----END PGP SIGNATURE----- --==-=-=-- --===============1667057393== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============1667057393==--