occur and a "Special" *Occur* Buffer.

occur and a "Special" *Occur* Buffer.

[David Hansen]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

Hello,

another one.  Is no one else using special display buffers?  BTW in
this case `t' seems to be the right choice for the optional
`get-buffer-window' argument, but i have to admit that i don't
really understand it ;)

David

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 675 bytes --]

*** replace.el	09 Mar 2007 06:07:54 +0100	1.253
--- replace.el	09 Mar 2007 08:09:07 +0100	
***************
*** 844,850 ****
         #'next-single-property-change)
       "No more matches")
      ;; In case the *Occur* buffer is visible in a nonselected window.
!     (set-window-point (get-buffer-window (current-buffer)) (point))
      (occur-mode-goto-occurrence)))
  \f
  (defface match
--- 844,850 ----
         #'next-single-property-change)
       "No more matches")
      ;; In case the *Occur* buffer is visible in a nonselected window.
!     (set-window-point (get-buffer-window (current-buffer) t) (point))
      (occur-mode-goto-occurrence)))
  \f
  (defface match

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: occur and a "Special" *Occur* Buffer.

[Stefan Monnier]

> another one.  Is no one else using special display buffers?  BTW in
> this case `t' seems to be the right choice for the optional
> `get-buffer-window' argument, but i have to admit that i don't
> really understand it ;)

Imagine that t means "any frame, even if it's displayed in my other office",
whereas 0 means "any frame so long as I might get to see it very soon".
So, yes, in this case I think t is just as good.  But the code should be
fixed to handle the case where the occur buffer is not displayed in
*any* window.


        Stefan

Re: occur and a "Special" *Occur* Buffer.

[David Hansen]

On Fri, 09 Mar 2007 10:32:56 -0500 Stefan Monnier wrote:

>> another one.  Is no one else using special display buffers?  BTW in
>> this case `t' seems to be the right choice for the optional
>> `get-buffer-window' argument, but i have to admit that i don't
>> really understand it ;)
>
> Imagine that t means "any frame, even if it's displayed in my other office",
> whereas 0 means "any frame so long as I might get to see it very soon".
> So, yes, in this case I think t is just as good.  But the code should be
> fixed to handle the case where the occur buffer is not displayed in
> *any* window.

How to get these "special buffer" fixes applied?  Shall I send one
patch summarizing it?  Assignment should be there at the time
(where's my $1?).

David

Re: occur and a "Special" *Occur* Buffer.

[Stefan Monnier]

>>> another one.  Is no one else using special display buffers?  BTW in
>>> this case `t' seems to be the right choice for the optional
>>> `get-buffer-window' argument, but i have to admit that i don't
>>> really understand it ;)
>> 
>> Imagine that t means "any frame, even if it's displayed in my other office",
>> whereas 0 means "any frame so long as I might get to see it very soon".
>> So, yes, in this case I think t is just as good.  But the code should be
>> fixed to handle the case where the occur buffer is not displayed in
>> *any* window.

> How to get these "special buffer" fixes applied?  Shall I send one
> patch summarizing it?  Assignment should be there at the time
> (where's my $1?).

Oh, they may have just fallen through.  I thought someone else installed
them.  I just installed a fix for the occur-next-error case.  If there's
some other fix that's still pending, please resend it, thank you.  And sorry
for the delay.


        Stefan

Re: occur and a "Special" *Occur* Buffer.

[David Hansen]

On Mon, 26 Mar 2007 11:10:46 -0400 Stefan Monnier wrote:

>>>> another one.  Is no one else using special display buffers?  BTW in
>>>> this case `t' seems to be the right choice for the optional
>>>> `get-buffer-window' argument, but i have to admit that i don't
>>>> really understand it ;)
>>> 
>>> Imagine that t means "any frame, even if it's displayed in my other office",
>>> whereas 0 means "any frame so long as I might get to see it very soon".
>>> So, yes, in this case I think t is just as good.  But the code should be
>>> fixed to handle the case where the occur buffer is not displayed in
>>> *any* window.
>
>> How to get these "special buffer" fixes applied?  Shall I send one
>> patch summarizing it?  Assignment should be there at the time
>> (where's my $1?).
>
> Oh, they may have just fallen through.  I thought someone else installed
> them.  I just installed a fix for the occur-next-error case.  If there's
> some other fix that's still pending, please resend it, thank you.  And sorry
> for the delay.

Here are the two others:

Index: lisp/comint.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/comint.el,v
retrieving revision 1.359
diff -u -r1.359 comint.el
--- lisp/comint.el	17 Mar 2007 18:08:50 -0000	1.359
+++ lisp/comint.el	27 Mar 2007 04:15:16 -0000
@@ -2959,7 +2959,7 @@
 (defun comint-dynamic-list-completions (completions)
   "List in help buffer sorted COMPLETIONS.
 Typing SPC flushes the help buffer."
-  (let ((window (get-buffer-window "*Completions*")))
+  (let ((window (get-buffer-window "*Completions*" 0)))
     (setq completions (sort completions 'string-lessp))
     (if (and (eq last-command this-command)
 	     window (window-live-p window) (window-buffer window)


Index: lisp/emacs-lisp/lisp.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/lisp.el,v
retrieving revision 1.78
diff -u -r1.78 lisp.el
--- lisp/emacs-lisp/lisp.el	21 Jan 2007 02:44:24 -0000	1.78
+++ lisp/emacs-lisp/lisp.el	27 Mar 2007 04:16:25 -0000
@@ -583,7 +583,7 @@
 considered."
   (interactive)
 
-  (let ((window (get-buffer-window "*Completions*")))
+  (let ((window (get-buffer-window "*Completions*" 0)))
     (if (and (eq last-command this-command)
 	     window (window-live-p window) (window-buffer window)
 	     (buffer-name (window-buffer window)))

Re: occur and a "Special" *Occur* Buffer.

[Stefan Monnier]

> Here are the two others:

Thanks, installed,


        Stefan