From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hansen Newsgroups: gmane.emacs.devel Subject: Re: [david.hansen@gmx.net: Re: comint's directory tracking doesn't understand \( or \)] Date: Sat, 10 Mar 2007 09:06:44 +0100 Organization: disorganized Message-ID: <87hcstsesr.fsf@localhorst.mine.nu> References: <871wk56tjh.fsf@localhorst.mine.nu> <87k5xw8b07.fsf@localhorst.mine.nu> <87irddev4c.fsf@catnip.gol.com> <873b4hjegy.fsf@localhorst.mine.nu> <87lki62nuw.fsf@stupidchicken.com> <87ejnyj754.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1173514151 5127 80.91.229.12 (10 Mar 2007 08:09:11 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2007 08:09:11 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 10 09:09:07 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HPwdV-00043S-KR for ged-emacs-devel@m.gmane.org; Sat, 10 Mar 2007 09:09:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HPwdq-0002Pp-RT for ged-emacs-devel@m.gmane.org; Sat, 10 Mar 2007 03:09:26 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HPwdb-0002Pj-Im for emacs-devel@gnu.org; Sat, 10 Mar 2007 03:09:11 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HPwdZ-0002PU-6p for emacs-devel@gnu.org; Sat, 10 Mar 2007 03:09:10 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HPwdZ-0002PR-1Z for emacs-devel@gnu.org; Sat, 10 Mar 2007 03:09:09 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HPwd8-0005FP-8M for emacs-devel@gnu.org; Sat, 10 Mar 2007 03:08:42 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1HPwcq-0008CH-F8 for emacs-devel@gnu.org; Sat, 10 Mar 2007 09:08:24 +0100 Original-Received: from e178061163.adsl.alicedsl.de ([85.178.61.163]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 10 Mar 2007 09:08:24 +0100 Original-Received: from david.hansen by e178061163.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 10 Mar 2007 09:08:24 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 33 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: e178061163.adsl.alicedsl.de Mail-Copies-To: nobody User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.95 (gnu/linux) Cancel-Lock: sha1:SkRq0G1QbATRNjGHz0UEY3RoZYw= X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67672 Archived-At: On Fri, 09 Mar 2007 19:04:39 -0500 Chong Yidong wrote: > I think the following patch fixes the same bug in a safer way. > > *** emacs/lisp/comint.el.~1.358.~ 2007-02-27 19:43:48.000000000 -0500 > --- emacs/lisp/comint.el 2007-03-09 18:44:15.000000000 -0500 > *************** > *** 1384,1390 **** > (let* ((first (if (if (fboundp 'w32-shell-dos-semantics) > (w32-shell-dos-semantics)) > "[^ \n\t\"'`]+\\|" > ! "[^ \n\t\"'`\\]+\\|\\\\[\"'`\\ \t]+\\|")) > (argpart (concat first > "\\(\"\\([^\"\\]\\|\\\\.\\)*\"\\|\ > '[^']*'\\|\ > --- 1384,1390 ---- > (let* ((first (if (if (fboundp 'w32-shell-dos-semantics) > (w32-shell-dos-semantics)) > "[^ \n\t\"'`]+\\|" > ! "\\([^ \n\t\"'`\\]\\|\\\\.\\)+\\|")) > (argpart (concat first > "\\(\"\\([^\"\\]\\|\\\\.\\)*\"\\|\ > '[^']*'\\|\ No it doesn't. (BTW that was my first suggestion). The string gets still splitted at members of `comint-delimiter-argument-list' (note that it's buffer local) no matter if they are escaped or not. I have to admit that it probably can be fixed with far less than a 200 line patch but I'm not willing to touch these regexps and i don't think it will result in anything "safer". David