Re: [david.hansen@gmx.net: Re: comint's directory tracking doesn't understand \( or \)]

[David Hansen <david.hansen@gmx.net>]

On Fri, 09 Mar 2007 19:04:39 -0500 Chong Yidong wrote:

> I think the following patch fixes the same bug in a safer way.
>
> *** emacs/lisp/comint.el.~1.358.~	2007-02-27 19:43:48.000000000 -0500
> --- emacs/lisp/comint.el	2007-03-09 18:44:15.000000000 -0500
> ***************
> *** 1384,1390 ****
>     (let* ((first (if (if (fboundp 'w32-shell-dos-semantics)
>   			(w32-shell-dos-semantics))
>   		    "[^ \n\t\"'`]+\\|"
> ! 		  "[^ \n\t\"'`\\]+\\|\\\\[\"'`\\ \t]+\\|"))
>   	 (argpart (concat first
>   			  "\\(\"\\([^\"\\]\\|\\\\.\\)*\"\\|\
>   '[^']*'\\|\
> --- 1384,1390 ----
>     (let* ((first (if (if (fboundp 'w32-shell-dos-semantics)
>   			(w32-shell-dos-semantics))
>   		    "[^ \n\t\"'`]+\\|"
> !                   "\\([^ \n\t\"'`\\]\\|\\\\.\\)+\\|"))
>   	 (argpart (concat first
>   			  "\\(\"\\([^\"\\]\\|\\\\.\\)*\"\\|\
>   '[^']*'\\|\

No it doesn't. (BTW that was my first suggestion).  The string gets
still splitted at members of `comint-delimiter-argument-list' (note
that it's buffer local) no matter if they are escaped or not.

I have to admit that it probably can be fixed with far less than a
200 line patch but I'm not willing to touch these regexps and i
don't think it will result in anything "safer".

David