From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: isearch multiple buffers Date: Sun, 21 Oct 2007 23:37:57 +0300 Organization: JURTA Message-ID: <87hckk9uoa.fsf@jurta.org> References: <87odfcggvl.fsf@jurta.org> <87myut77c2.fsf@jurta.org> <873awlidih.fsf@offby1.atm01.sea.blarg.net> <871wc51any.fsf@jurta.org> <878x6a6ktw.fsf@jurta.org> <871wc15m2b.fsf@jurta.org> <87lk9ylkbb.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192999740 23117 80.91.229.12 (21 Oct 2007 20:49:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Oct 2007 20:49:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 21 22:49:00 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IjhjE-0000vY-20 for ged-emacs-devel@m.gmane.org; Sun, 21 Oct 2007 22:48:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ijhj6-00064T-Ef for ged-emacs-devel@m.gmane.org; Sun, 21 Oct 2007 16:48:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IjhiR-0005Km-BH for emacs-devel@gnu.org; Sun, 21 Oct 2007 16:48:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IjhiQ-0005JV-Jq for emacs-devel@gnu.org; Sun, 21 Oct 2007 16:48:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjhiQ-0005JC-8A for emacs-devel@gnu.org; Sun, 21 Oct 2007 16:48:06 -0400 Original-Received: from mailman.kiev.sovam.com ([89.162.150.100]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IjhiL-0006Mt-I0; Sun, 21 Oct 2007 16:48:01 -0400 Original-Received: from relay01.kiev.sovam.com ([62.64.120.200]) by mailman.kiev.sovam.com with esmtp (Exim 4.63 (FreeBSD)) (envelope-from ) id 1IjkVw-0001kD-V6; Sun, 21 Oct 2007 23:47:24 +0000 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by relay01.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1Ijhi7-000MIF-G2; Sun, 21 Oct 2007 23:47:48 +0300 In-Reply-To: (Richard Stallman's message of "Sun\, 21 Oct 2007 03\:26\:47 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-Scanner-Signature: b22dd54e5e410b0526d530b08df0ebb5 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 1649 [Oct 21 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: none X-SpamTest-Rate: 25 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81401 Archived-At: > isearch-multi.el seems like a better name for the new file. This name is too long. What about isearch-x.el? It has two meanings: "x" means "isearch extra extensions", and "x" means "cross-file, cross-buffer search". However, isearch-x.el causes name conflicts with international/isearch-x.el. So alternative short names are isearchx.el or xisearch.el. > Also I implemented a new minor mode isearch-buffers-minor-mode > that sets a group of variables necessary for this feature. > Turning off this minor mode deletes all created buffer-local bindings. > So any major mode that uses this feature can simply set the variable > isearch-buffers-next-buffer-function and call isearch-buffers-minor-mode. > > To make this a minor mode is undesirable because we do not want users > to enable and disable it. I think it should simply be a subroution > for that major modes can call. It is likely that there are some users who won't like this feature. I think we shouldn't make it hard to disable. Also this minor mode could provide an indication in the mode line (e.g. "X" or "X-Isearch" to mean cross-buffer search), so when the search goes to another file, it will not surprise users. > ! (if (and (boundp 'isearch-buffers-next-buffer-function) > ! isearch-buffers-next-buffer-function > ! (boundp 'isearch-buffers-current-buffer) > > Why test boundp of these variables. Isn't it better to have them > always always bound, and just test for non-nil? OK, I will add the ###autoload cookie to their defvar in the source file. -- Juri Linkov http://www.jurta.org/emacs/