From: mah@everybody.org (Mark A. Hershberger)
To: emacs-devel@gnu.org
Subject: Re: unicode build: "comparison is always true" warnings
Date: Fri, 23 Nov 2007 12:42:46 -0500 [thread overview]
Message-ID: <87hcjcoo2x.fsf@everybody.org> (raw)
In-Reply-To: jwvir3t6lxw.fsf-monnier+emacs@gnu.org
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> There is also a warning from movemail.c:
>> warning: the use of `mktemp' is dangerous, better use `mkstemp' or
>> `mkdtemp'
>
> This one looks bad.
I attempted to fix this. It has been ages since I had to write C, but
this fix is almost identical to the one here: http://xrl.us/bbocw
I'll apply if this looks ok.
diff -u -b -r1.88 movemail.c
--- movemail.c 26 Jul 2007 05:26:12 -0000 1.88
+++ movemail.c 23 Nov 2007 17:38:40 -0000
@@ -325,14 +325,20 @@
p--;
*p = 0;
strcpy (p, "EXXXXXX");
+#ifndef HAVE_MKSTEMP
mktemp (tempname);
unlink (tempname);
+#endif
while (1)
{
/* Create the lock file, but not under the lock file name. */
/* Give up if cannot do that. */
+#ifndef HAVE_MKSTEMP
desc = open (tempname, O_WRONLY | O_CREAT | O_EXCL, 0666);
+#else
+ desc = mkstemp (tempname);
+#endif
if (desc < 0)
{
char *message = (char *) xmalloc (strlen (tempname) + 50);
--
http://hexmode.com/
GPG Fingerprint: 7E15 362D A32C DFAB E4D2 B37A 735E F10A 2DFC BFF5
The most beautiful experience we can have is the mysterious.
-- Albert Einstein, The World As I See it
next prev parent reply other threads:[~2007-11-23 17:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 4:57 unicode build: "comparison is always true" warnings Mark A. Hershberger
2007-11-23 15:09 ` Stefan Monnier
2007-11-23 17:42 ` Mark A. Hershberger [this message]
2007-11-23 18:07 ` Andreas Schwab
2007-11-23 18:40 ` Stefan Monnier
2007-11-23 18:52 ` Andreas Schwab
2007-11-23 20:02 ` Stefan Monnier
2007-11-23 20:12 ` Glenn Morris
2007-11-23 21:22 ` Andreas Schwab
2007-11-23 21:35 ` Mark A. Hershberger
2007-11-23 21:53 ` Andreas Schwab
2007-11-24 1:49 ` Mark A. Hershberger
2007-11-24 8:26 ` Andreas Schwab
2007-11-24 9:30 ` Jan Djärv
2007-11-24 9:46 ` Andreas Schwab
2007-11-24 11:23 ` Matthieu Lemerre
2007-11-24 14:16 ` Andreas Schwab
2007-11-24 14:49 ` Matthieu Lemerre
2007-11-24 15:20 ` David Kastrup
2007-11-24 17:00 ` Andreas Schwab
2007-11-24 18:21 ` David Kastrup
[not found] ` <4747FDF6.3050203@swipnet.se>
[not found] ` <je1wagrkn9.fsf@sykes.suse.de>
[not found] ` <4748064D.6010405@swipnet.se>
[not found] ` <jelk8nrido.fsf@sykes.suse.de>
2007-11-24 13:08 ` Jan Djärv
2007-11-24 13:57 ` Andreas Schwab
2007-11-24 18:24 ` Mark A. Hershberger
2007-11-23 18:42 ` Mark A. Hershberger
2007-11-23 18:54 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hcjcoo2x.fsf@everybody.org \
--to=mah@everybody.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.