From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: doc-view support for bookmark.el Date: Tue, 25 Dec 2007 20:00:37 +0100 Message-ID: <87hci638h6.fsf@member.fsf.org> References: <8763yn3v07.fsf@member.fsf.org> <87prwu3kg0.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1198609276 29015 80.91.229.12 (25 Dec 2007 19:01:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Dec 2007 19:01:16 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 25 20:01:29 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J7F1W-00015Q-GS for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 20:01:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7F1C-0008NK-47 for ged-emacs-devel@m.gmane.org; Tue, 25 Dec 2007 14:00:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J7F18-0008Jv-2Q for emacs-devel@gnu.org; Tue, 25 Dec 2007 14:00:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J7F16-0008GF-Gm for emacs-devel@gnu.org; Tue, 25 Dec 2007 14:00:41 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J7F16-0008G6-DX for emacs-devel@gnu.org; Tue, 25 Dec 2007 14:00:40 -0500 Original-Received: from out4.smtp.messagingengine.com ([66.111.4.28]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J7F16-0008Cu-3Z for emacs-devel@gnu.org; Tue, 25 Dec 2007 14:00:40 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id DBE817E771 for ; Tue, 25 Dec 2007 14:00:39 -0500 (EST) Original-Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 25 Dec 2007 14:00:39 -0500 X-Sasl-enc: nq8sz3ZodDs7Bo8X3pArQtRADPkVuaKJmt3F6Biq/4EX 1198609239 Original-Received: from baldur (dslb-084-063-018-200.pools.arcor-ip.net [84.63.18.200]) by mail.messagingengine.com (Postfix) with ESMTP id 3575E4ADE for ; Tue, 25 Dec 2007 14:00:38 -0500 (EST) Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: (Stefan Monnier's message of "Tue, 25 Dec 2007 12:32:02 -0500") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85452 Archived-At: Stefan Monnier writes: Hi Stefan, >> Sure, a general interface would be a good idea. Do you propose an >> one? > >> A simple approach could be to add 2 new variables > >> - bookmark-make-cell-function: A function that creates the record part >> of the bookmark (default: the current bookmark-make-cell after >> renaming it appropriately) > >> - bookmark-jump-function: A function that jumps to the given bookmark >> location without selecting it. (default: the current >> bookmark-jump-noselect) > >> What do you think? > > I don't have time to look into it right now, but I'd have expected that > the second one is not needed: doc-view's bookmark-make-cell-function > would create a bookmark entry which contains a callback to doc-view, so > that bookmark-jump would not need a bookmark-jump-function, or in other > words the bookmark-jump-function shouldn't be a global (buffer-local) > variable, but an (optional) entry in each bookmark. That's a very good idea. I'll try to implement it when I find some time. Bye, Tassilo