BUG: Clocking deeply nested tasks

BUG: Clocking deeply nested tasks

[Bernt Hansen]

Hi Carsten,

I ran into another bug a few minutes ago.

,----[ test.org ]
| #+STARTUP: odd
| * Task1
| *** Task2
| ***** Task3
| ******* Task4
| ********* Task5
| *********** Task6
| 	    :CLOCK:
| 	    CLOCK: [2008-02-27 Wed 14:30]--[2008-02-27 Wed 14:44] =>  0:14
| 	    :END:
`----

,----[ minimal.emacs ]
| (setq org-use-fast-todo-selection t)
| (setq inhibit-splash-screen t)
| (global-font-lock-mode t)
| (add-to-list 'load-path (expand-file-name "~/git/org-mode"))
| (add-to-list 'auto-mode-alist '("\\.org$" . org-mode))
| (require 'org-install)
| (define-key global-map "\C-ca" 'org-agenda)
| (custom-set-variables
|  '(org-agenda-files (quote ("~/org/test.org"))))
`----

Key strokes:

| Key                    | Notes                   |
|------------------------+-------------------------|
| C-x C-f ~/org/test.org | Open org file           |
| C-c C-a                | Expand everything       |
| C-c C-x C-d            | Clock summaries by task |

This gives the error

org-put-clock-overlay: Wrong type argument: wholenump, -1

If I use odd even levels I can get many more nested levels before
triggering this problem so it seems to be related to the number of stars
in the tasks.  With #+STARTUP: oddeven it works for

********* TaskN (9 stars)

but

********** Task N (10 stars)

fails.


Regards,
Bernt

[PATCH] Allow more asterisks in tasks when summarizing clock time

[Bernt Hansen]

10 asterisks is only 6 levels deep when odd levels only are used.
This increases the number of asterisks to 40 (still an arbitrary number)
but it's much larger than the current limit of 10.

This fixes C-c C-x C-d when trying to summarize clock time on a
deeply nested task

,----[ test.org ]
| * Task1
| *** Task2
| ***** Task3
| ******* Task4
| ********* Task5
| *********** Task6
| 	    :CLOCK:
| 	    CLOCK: [2008-02-27 Wed 14:30]--[2008-02-27 Wed 14:44] =>  0:14
| 	    :END:
`----
---

This patch works for me.  You can apply this patch directly in git by
saving this message in mbox format (e.g. file.mbox) and then doing 

$ git am file.mbox

This will create the commit on the current HEAD with all of the provided
commit message text.

The text between the three dashes (---) above and the start of the
diffstat below (org.el |    2 +-) is discarded which is why I'm writing
my extra notes here :)

HTH,
-Bernt


 org.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/org.el b/org.el
index 0c2762d..504dcd5 100644
--- a/org.el
+++ b/org.el
@@ -18919,7 +18919,7 @@ will be easy to remove."
 		     (make-string (+ off (max 0 (- c (current-column)))) ?.)
 		     (org-add-props (format "%s %2d:%02d%s"
 					    (make-string l ?*) h m
-					    (make-string (- 10 l) ?\ ))
+					    (make-string (- 40 l) ?\ ))
 			 '(face secondary-selection))
 		     ""))
     (if (not (featurep 'xemacs))
-- 
1.5.4.3.192.g923d4

Re: [PATCH] Allow more asterisks in tasks when summarizing clock time

[Bastien]

Hi Bernt,

Bernt Hansen <bernt@norang.ca> writes:

> 10 asterisks is only 6 levels deep when odd levels only are used.
> This increases the number of asterisks to 40 (still an arbitrary number)
> but it's much larger than the current limit of 10.

Thanks for the patch.  

I applied it, but used an arbitrary limit of 16 instead of 40, since 16
asterisks characters are required for 8 (odd) levels, and 8 seems to be
quite a natural limit for Org levels.

-- 
Bastien

Re: [PATCH] Allow more asterisks in tasks when summarizing clock time

[Bernt Hansen]

Thanks :)

Bastien <bzg@altern.org> writes:

> Hi Bernt,
>
> Bernt Hansen <bernt@norang.ca> writes:
>
>> 10 asterisks is only 6 levels deep when odd levels only are used.
>> This increases the number of asterisks to 40 (still an arbitrary number)
>> but it's much larger than the current limit of 10.
>
> Thanks for the patch.  
>
> I applied it, but used an arbitrary limit of 16 instead of 40, since 16
> asterisks characters are required for 8 (odd) levels, and 8 seems to be
> quite a natural limit for Org levels.
>
> -- 
> Bastien