From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Jackson Subject: Re: Bug? Installing from git master Date: Mon, 03 Mar 2008 11:01:46 +0000 Message-ID: <87hcfof4v9.fsf@shellarchive.co.uk> References: <47C86E0B.4010107@gmx.de> <9AC7F26F-5F31-4DD9-98A0-A2CE5353C218@science.uva.nl> <87ejavjtyu.fsf@bzg.ath.cx> <87tzjrgyyk.fsf@bzg.ath.cx> <20080302233409.GA23239@atlantic.linksys.moosehall> <87hcfod5rh.fsf@bzg.ath.cx> <12BAC2AD-0337-4FBF-86E4-D2676DB7F616@science.uva.nl> <87tzjoxfik.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JW8Qd-0003hV-Sh for emacs-orgmode@gnu.org; Mon, 03 Mar 2008 06:01:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JW8Qb-0003gd-Hp for emacs-orgmode@gnu.org; Mon, 03 Mar 2008 06:01:54 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JW8Qa-0003gV-6R for emacs-orgmode@gnu.org; Mon, 03 Mar 2008 06:01:52 -0500 Received: from c.painless.aaisp.net.uk ([81.187.30.53]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JW8QZ-0002zs-QE for emacs-orgmode@gnu.org; Mon, 03 Mar 2008 06:01:51 -0500 In-Reply-To: <87tzjoxfik.fsf@bzg.ath.cx> (Bastien's message of "Mon, 03 Mar 2008 10:34:27 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org Bastien writes: > Carsten Dominik writes: > >> I did not realize that erc is not supported on all Emacs versions, >> to we clearly need to cater for this. Wither by taking it out >> of that variable, of my making the require fail silently. >> We could, for example, wrap the require into condition-case and only >> pus out a message, not raise a signal. > > I have pushed a commit taking this later route. Slow down... :) As mentioned orc-irc is meant to be generic so it's still not quite right. I sent an email to you and Carsten about having a loadablep (bad name?) function exposed by the module which would give it a chance to do some requires and setting up too. Might be interesting to look at the ERC code and check how they do it... Here is my (rough) suggestion again: --8<---------------cut here---------------start------------->8--- (defun org-load-module (module-name) (let ((sym (intern (concat module-name "-loadablep")))) (if (fboundp sym) (when (funcall sym) (require (intern module-name))) (error "org modules must have a -loadablep defun.")))) --8<---------------cut here---------------end--------------->8--- Cheers, Phil -- Phil Jackson http://www.shellarchive.co.uk