From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bastien Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Fri, 07 Mar 2008 12:29:03 +0000 Message-ID: <87hcfi3egg.fsf@bzg.ath.cx> References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> <87ejan7xhq.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204892965 20743 80.91.229.12 (7 Mar 2008 12:29:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Mar 2008 12:29:25 +0000 (UTC) Cc: Karl Fogel , Stefan Monnier , Reiner Steib , emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 07 13:29:51 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JXbhu-0001av-SG for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 13:29:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXbhN-0002Gj-4K for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 07:29:17 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JXbhJ-0002Ez-38 for emacs-devel@gnu.org; Fri, 07 Mar 2008 07:29:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JXbhH-0002CB-DN for emacs-devel@gnu.org; Fri, 07 Mar 2008 07:29:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXbhH-0002C4-5g for emacs-devel@gnu.org; Fri, 07 Mar 2008 07:29:11 -0500 Original-Received: from ug-out-1314.google.com ([66.249.92.173]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JXbhG-00007q-9D for emacs-devel@gnu.org; Fri, 07 Mar 2008 07:29:10 -0500 Original-Received: by ug-out-1314.google.com with SMTP id a2so4214239ugf.48 for ; Fri, 07 Mar 2008 04:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:received:from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; bh=EEDTOkjGUqS6e3BB6dbAk9Tcg4Dsxhztu2Xqgg8wUog=; b=jpWfXa0kXfFprzbRcdvCiQpd8Xir+Hxt0gNF/JNK8zhIntbv94XJgwhl2St2FjHSL5U1Jr+tHYPYoDwJA6h9TKIhEi9HcqKLzqfy/wUzGZCgcNi2bLoeCb4kNBJ4Qd2OoV/OXcBQgo3xG+AY204ixKfY+mnXUAqFpaNGJSK/fck= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date:message-id:mime-version:content-type:sender; b=fEEny3GLgzkvhU9qhBDah2e4zRefQRuvISIulD4kQgQi4Ur/RsUFv42rY/gHrUuerkJRg7zR2CIDcN00pqI8r/mnsdoGCispsNa9t3Zut4uhe59Da0dHhWS/8gQpBsVDLQ+juR+MImdF10e4eBiUP2SN1iPt0TRUjUYVVBcFQQA= Original-Received: by 10.78.168.1 with SMTP id q1mr3606016hue.2.1204892948226; Fri, 07 Mar 2008 04:29:08 -0800 (PST) Original-Received: from bzg.ath.cx ( [81.99.213.34]) by mx.google.com with ESMTPS id z34sm7433093ikz.8.2008.03.07.04.29.05 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 07 Mar 2008 04:29:07 -0800 (PST) Original-Received: by bzg.ath.cx (Postfix, from userid 1000) id 975A3157920; Fri, 7 Mar 2008 12:29:03 +0000 (GMT) In-Reply-To: <87ejan7xhq.fsf@member.fsf.org> (Tassilo Horn's message of "Fri, 07 Mar 2008 09:24:17 +0100") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91628 Archived-At: Tassilo Horn writes: > Bastien writes: >> >> This boils down to this: having a `bookmark-make-name-function' doing >> for the names of the bookmarks what `bookmark-make-cell-function' does >> for the records. This would be locally set depending on the mode >> we're in. >> >> For now the the name of the bookmark is set by >> bookmark-buffer-file-name which doesn't return anything unless you are >> in a buffer visiting a file or an Info node, or dired. > > Hm, looking at the code `bookmark-buffer-file-name' is only called for > buffers that don't have `bookmark-make-record-function' set locally, so > I don't see why you would need that? I think you mean: `bookmark-make-cell-function', right? Karl added this after I wrote the text you quote above. > Or am I late again and Karl's and Stefan's changes already do care oy > everything we need? Yes, they do! Now a mode can define `bookmark-make-cell-function' so that it tells bookmark.el how to set the name of the bookmark. Some people talk, some people work. :) -- Bastien