Re: 23.0.60; doc-view: occasionally stuck at welcome screen

[Tassilo Horn <tassilo@member.fsf.org>]

Markus Triska <markus.triska@gmx.at> writes:

> When I do M-x doc-view-clear-cache, and then:
>
>    $ emacs -Q file.pdf
>
> doc-view correctly displays the file (for example, with:
> http://www.logic.at/prolog/testqueens.pdf ). If I quit, and again
>
>    $ emacs -Q file.pdf
>
> then doc-view is stuck at the welcome screen. (When I press "C-c" four
> times, it displays the document.)

I can reproduce that.  Hitting PageDown on the welcome screen is a
woraround, too.

> When I do M-x doc-view-clear-cache, I can again view the document with
> "emacs -Q file.pdf", but it fails on every later attempt ("emacs
> -Q..."), until I clear the cache again.

I've located the source of the problem.  In doc-view-display the

  (dolist (win (get-buffer-window-list buffer nil t)) ...)

doesn't iterate over any windows, e.g. get-buffer-window-list returns
nil.  I don't know why.  Maybe the with-current-buffer form shadows the
buffer-window association?

The caller is doc-view-initiate-display and the problem occurs when a
doc is already converted and thus the cached png files are used.  Then
the call is

  (doc-view-display (current-buffer) 'force)

Since the current buffer (which shows the welcome screen) in visible,
get-buffer-window-list should return that window...

Bye,
Tassilo