From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.devel Subject: Re: update of the EasyPG integration patch (Re: minor fixes for EasyPG Date: Mon, 28 Apr 2008 10:29:14 +0900 Message-ID: <87hcdmlqc5.fsf@broken.deisui.org> References: <877ifjd24v.fsf@broken.deisui.org> <87r6dqywer.fsf@grepfind.mwolson.org> <87r6d338n2.fsf_-_@broken.deisui.org> <200804272107.m3RL7K54000008@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1209346172 457 80.91.229.12 (28 Apr 2008 01:29:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Apr 2008 01:29:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 28 03:30:08 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JqIBy-000173-CU for ged-emacs-devel@m.gmane.org; Mon, 28 Apr 2008 03:30:06 +0200 Original-Received: from localhost ([127.0.0.1]:43840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqIBH-00035Z-R0 for ged-emacs-devel@m.gmane.org; Sun, 27 Apr 2008 21:29:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JqIBD-000335-6A for emacs-devel@gnu.org; Sun, 27 Apr 2008 21:29:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JqIBB-00030q-Ob for emacs-devel@gnu.org; Sun, 27 Apr 2008 21:29:18 -0400 Original-Received: from [199.232.76.173] (port=48764 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqIBB-00030f-Em for emacs-devel@gnu.org; Sun, 27 Apr 2008 21:29:17 -0400 Original-Received: from wf-out-1314.google.com ([209.85.200.171]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JqIBB-0002ST-0U for emacs-devel@gnu.org; Sun, 27 Apr 2008 21:29:17 -0400 Original-Received: by wf-out-1314.google.com with SMTP id 29so3986203wff.24 for ; Sun, 27 Apr 2008 18:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references:date:in-reply-to:message-id:user-agent:mime-version:content-type:sender; bh=of1/kjStCo2lz1kbpdHezFE2mOs6spE+ot7xebe85ok=; b=P073gqQhisjqWt7FBSYexpc/AYcwVjjYciZky2JtHlH+RNybO3N/qYosci9XcXxjJu7EgqDGbZN1MXYMkDG/l5sR7JvKAETEnOdHxNomdmtHSGN6kDza+gNhHQ95Qpg4WKWHsm5vzfBw3h03o57QVnumplWjhPiE5e64sKWWQIk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id:user-agent:mime-version:content-type:sender; b=tH7+7p1aAfX53v0o+MID0EoJk76uiRTqME1d2UvA6pdnvByRexL9J1T/3H9wH4CVAFdvQWYgzcdpDnQMtBuo/ZvO9b87k4JPZfY3aWXNIECxsjTdM+ANH4+mXx+3RXyuljG9yNYzalrau//ZwFWy/3O9Qn3z7F42c3EWUwVnJt0= Original-Received: by 10.142.70.13 with SMTP id s13mr2005538wfa.162.1209346155683; Sun, 27 Apr 2008 18:29:15 -0700 (PDT) Original-Received: from broken ( [202.83.187.18]) by mx.google.com with ESMTPS id 22sm10912908wfi.12.2008.04.27.18.29.13 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 27 Apr 2008 18:29:15 -0700 (PDT) In-Reply-To: <200804272107.m3RL7K54000008@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Sun, 27 Apr 2008 14:07:20 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96037 Archived-At: --=-=-= Dan Nicolaescu writes: > Can you please also add menus to the new modes added by EasyPG? > (epa-key-list-mode surely could use one) Sure, here it is. BTW, I found a couple of typos when testing the menu. The patch also includes a fix for them. 2008-04-28 Daiki Ueno * epa.el (epa-key-list-mode-map): Add menu. (epa-delete-keys): Fix typo. (epa-import-keys): Fix typo. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=epa-key-list-menu.diff Index: lisp/epa.el =================================================================== RCS file: /sources/emacs/emacs/lisp/epa.el,v retrieving revision 1.8 diff -c -r1.8 epa.el *** lisp/epa.el 27 Apr 2008 19:49:15 -0000 1.8 --- lisp/epa.el 28 Apr 2008 01:28:14 -0000 *************** *** 201,207 **** (defvar epa-last-coding-system-specified nil) (defvar epa-key-list-mode-map ! (let ((keymap (make-sparse-keymap))) (define-key keymap "m" 'epa-mark-key) (define-key keymap "u" 'epa-unmark-key) (define-key keymap "d" 'epa-decrypt-file) --- 201,208 ---- (defvar epa-last-coding-system-specified nil) (defvar epa-key-list-mode-map ! (let ((keymap (make-sparse-keymap)) ! (menu-map (make-sparse-keymap))) (define-key keymap "m" 'epa-mark-key) (define-key keymap "u" 'epa-unmark-key) (define-key keymap "d" 'epa-decrypt-file) *************** *** 217,222 **** --- 218,241 ---- (define-key keymap " " 'scroll-up) (define-key keymap [delete] 'scroll-down) (define-key keymap "q" 'epa-exit-buffer) + (define-key keymap [menu-bar epa-key-list-mode] (cons "Keys" menu-map)) + (define-key menu-map [epa-key-list-delete-keys] + '(menu-item "Delete keys" epa-delete-keys + :help "Delete marked keys")) + (define-key menu-map [epa-key-list-import-keys] + '(menu-item "Import keys" epa-import-keys + :help "Import keys from a file")) + (define-key menu-map [epa-key-list-export-keys] + '(menu-item "Export keys" epa-export-keys + :help "Export marked keys to a file")) + (define-key menu-map [separator-epa-key-list] + '(menu-item "--")) + (define-key menu-map [epa-key-list-unmark-key] + '(menu-item "Unmark key" epa-unmark-key + :help "Unmark a key")) + (define-key menu-map [epa-key-list-mark-key] + '(menu-item "Mark key" epa-mark-key + :help "Mark a key")) keymap)) (defvar epa-key-mode-map *************** *** 1094,1100 **** (message "Deleting...") (epg-delete-keys context keys allow-secret) (message "Deleting...done") ! (apply #'epa-list-keys epa-list-keys-arguments))) ;;;###autoload (defun epa-import-keys (file) --- 1113,1119 ---- (message "Deleting...") (epg-delete-keys context keys allow-secret) (message "Deleting...done") ! (apply #'epa--list-keys epa-list-keys-arguments))) ;;;###autoload (defun epa-import-keys (file) *************** *** 1113,1119 **** (epa-display-info (epg-import-result-to-string (epg-context-result-for context 'import)))) (if (eq major-mode 'epa-key-list-mode) ! (apply #'epa-list-keys epa-list-keys-arguments)))) ;;;###autoload (defun epa-import-keys-region (start end) --- 1132,1138 ---- (epa-display-info (epg-import-result-to-string (epg-context-result-for context 'import)))) (if (eq major-mode 'epa-key-list-mode) ! (apply #'epa--list-keys epa-list-keys-arguments)))) ;;;###autoload (defun epa-import-keys-region (start end) --=-=-= Regards, -- Daiki Ueno --=-=-=--