From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: The latest lisp/faces.el changes seem to break color-themes again Date: Thu, 16 Oct 2008 12:07:15 -0400 Message-ID: <87hc7ccymk.fsf@cyd.mit.edu> References: <87skqxw20c.fsf@anzu.internal.golden-gryphon.com> <87od1lvxa9.fsf@anzu.internal.golden-gryphon.com> <87abd4vfyb.fsf@grepfind.mwolson.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1224173444 18491 80.91.229.12 (16 Oct 2008 16:10:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Oct 2008 16:10:44 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Olson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 16 18:11:44 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KqVRt-0008Np-Ob for ged-emacs-devel@m.gmane.org; Thu, 16 Oct 2008 18:11:42 +0200 Original-Received: from localhost ([127.0.0.1]:51969 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqVQo-0003Ve-OW for ged-emacs-devel@m.gmane.org; Thu, 16 Oct 2008 12:10:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqVNU-0002GH-Ny for emacs-devel@gnu.org; Thu, 16 Oct 2008 12:07:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqVNT-0002Fd-4N for emacs-devel@gnu.org; Thu, 16 Oct 2008 12:07:08 -0400 Original-Received: from [199.232.76.173] (port=49905 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqVNS-0002FP-MF for emacs-devel@gnu.org; Thu, 16 Oct 2008 12:07:06 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:43817) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KqVNR-00079C-FA; Thu, 16 Oct 2008 12:07:05 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 6E11F57E095; Thu, 16 Oct 2008 12:07:15 -0400 (EDT) In-Reply-To: <87abd4vfyb.fsf@grepfind.mwolson.org> (Michael Olson's message of "Thu, 16 Oct 2008 06:15:40 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104556 Archived-At: Michael Olson writes: > Miles Bader writes: > >> Manoj Srivastava writes: >>>> Are color themes supposed to be supported? >>> >>> While I am hoping they are, the actual code that is made invalid >>> is immaterial: color-themes are on example of long-standing user >>> customization that is breaking. While user customizations are not >>> always going to be supportable, I think one ought to minimize such >>> breakage, since it is likely to be seen as regressions. >> >> It's just that I have a vague memory of color-themes doing some decidely >> dodgy stuff. (I haven't looked at in ages though) > > The problem could possibly be due to Emacs having problems with using > ":foreground nil" in a defface statement. I just received a patch for > EMMS to that effect. Could you come up with a test case that shows how Emacs fails now, compared to before?