From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: emacsclient's option decoding code Date: Mon, 03 Nov 2008 15:19:42 -0500 Message-ID: <87hc6o4l5t.fsf@cyd.mit.edu> References: <87wsflyf80.fsf@cyd.mit.edu> <87k5blzphq.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1225743595 22526 80.91.229.12 (3 Nov 2008 20:19:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Nov 2008 20:19:55 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 03 21:20:57 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kx5ut-0007D1-4L for ged-emacs-devel@m.gmane.org; Mon, 03 Nov 2008 21:20:51 +0100 Original-Received: from localhost ([127.0.0.1]:48624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kx5tm-00034d-0Z for ged-emacs-devel@m.gmane.org; Mon, 03 Nov 2008 15:19:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kx5th-00034F-8d for emacs-devel@gnu.org; Mon, 03 Nov 2008 15:19:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kx5tf-00033q-Kb for emacs-devel@gnu.org; Mon, 03 Nov 2008 15:19:36 -0500 Original-Received: from [199.232.76.173] (port=47619 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kx5tf-00033m-AZ for emacs-devel@gnu.org; Mon, 03 Nov 2008 15:19:35 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:35494) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kx5td-00084D-Vw; Mon, 03 Nov 2008 15:19:34 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 1524957E1D1; Mon, 3 Nov 2008 15:19:42 -0500 (EST) In-Reply-To: (Eli Zaretskii's message of "Mon, 03 Nov 2008 22:06:27 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105313 Archived-At: Eli Zaretskii writes: > I think it's unclean that the w32 port has make-frame-on-display > fboundp, but it's dysfunctional when called. If make-frame-on-display > can be made to work on Windows, provided that `display' is nil (or > maybe it should ignore `display' even if non-nil?), that would be a > cleaner and more general change. I agree. Maybe something like this? *** trunk/lisp/frame.el.~1.287.~ 2008-11-03 11:44:19.000000000 -0500 --- trunk/lisp/frame.el 2008-11-03 15:18:41.000000000 -0500 *************** *** 610,628 **** "Make a frame on X display DISPLAY. The optional second argument PARAMETERS specifies additional frame parameters." (interactive "sMake frame on display: ") ! (if (featurep 'ns) ! (progn ! (when (and (boundp 'ns-initialized) (not ns-initialized)) ! (setq x-display-name display) ! (ns-initialize-window-system)) ! (make-frame `((window-system . ns) (display . ,display) . ,parameters))) ! (progn ! (unless (string-match "\\`[^:]*:[0-9]+\\(\\.[0-9]+\\)?\\'" display) ! (error "Invalid display, not HOST:SERVER or HOST:SERVER.SCREEN")) ! (when (and (boundp 'x-initialized) (not x-initialized)) ! (setq x-display-name display) ! (x-initialize-window-system)) ! (make-frame `((window-system . x) (display . ,display) . ,parameters))))) (defun make-frame-on-tty (tty type &optional parameters) "Make a frame on terminal device TTY. --- 610,632 ---- "Make a frame on X display DISPLAY. The optional second argument PARAMETERS specifies additional frame parameters." (interactive "sMake frame on display: ") ! (cond ((featurep 'ns) ! (when (and (boundp 'ns-initialized) (not ns-initialized)) ! (setq x-display-name display) ! (ns-initialize-window-system)) ! (make-frame `((window-system . ns) ! (display . ,display) . ,parameters))) ! ((eq system-type 'windows-nt) ! ;; Ignore DISPLAY. ! (make-frame parameters)) ! (t ! (unless (string-match "\\`[^:]*:[0-9]+\\(\\.[0-9]+\\)?\\'" display) ! (error "Invalid display, not HOST:SERVER or HOST:SERVER.SCREEN")) ! (when (and (boundp 'x-initialized) (not x-initialized)) ! (setq x-display-name display) ! (x-initialize-window-system)) ! (make-frame `((window-system . x) ! (display . ,display) . ,parameters))))) (defun make-frame-on-tty (tty type &optional parameters) "Make a frame on terminal device TTY.