From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Completions in Semantic Date: Wed, 21 Oct 2009 10:07:47 -0400 Message-ID: <87hbtsn8lo.fsf@stupidchicken.com> References: <87tyxwxq6t.fsf@stupidchicken.com> <1255924220.6961.1039.camel@projectile.siege-engine.com> <1255996360.6961.1086.camel@projectile.siege-engine.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1256139025 12175 80.91.229.12 (21 Oct 2009 15:30:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Oct 2009 15:30:25 +0000 (UTC) Cc: emacs-devel@gnu.org To: eric@siege-engine.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 21 17:30:15 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N0d88-0004FQ-8d for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2009 17:29:41 +0200 Original-Received: from localhost ([127.0.0.1]:41788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0d85-0004nv-VE for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2009 11:29:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0br1-0000tk-2H for emacs-devel@gnu.org; Wed, 21 Oct 2009 10:07:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0bqw-0000oU-H9 for emacs-devel@gnu.org; Wed, 21 Oct 2009 10:07:54 -0400 Original-Received: from [199.232.76.173] (port=45449 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0bqw-0000oG-8G for emacs-devel@gnu.org; Wed, 21 Oct 2009 10:07:50 -0400 Original-Received: from pantheon-po43.its.yale.edu ([130.132.50.104]:49318) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N0bqv-0000aQ-Op for emacs-devel@gnu.org; Wed, 21 Oct 2009 10:07:49 -0400 Original-Received: from furry (dhcp128036014244.central.yale.edu [128.36.14.244]) (authenticated bits=0) by pantheon-po43.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n9LE7mSB025909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 21 Oct 2009 10:07:48 -0400 Original-Received: by furry (Postfix, from userid 1000) id B139EC070; Wed, 21 Oct 2009 10:07:47 -0400 (EDT) In-Reply-To: <1255996360.6961.1086.camel@projectile.siege-engine.com> (Eric M. Ludlam's message of "Mon, 19 Oct 2009 19:52:40 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116292 Archived-At: "Eric M. Ludlam" writes: > On Sun, 2009-10-18 at 23:50 -0400, Eric M. Ludlam wrote: >> For your particular example in xdisp.c, it seems the contents of >> xdisp.c fails to parse properly. It seems to be related to the P_ >> macro, and one of the uses of it involving a line-end in the middle. >> I've narrowed it down and will see if I can fix it. > > To reply to myself, I checked changes into the CEDET repository for the > C preprocessor handling to fix the bug found here in xdisp. > > By way of side effect, the completion problem originally posed is also > fixed, as there is no "window" symbol in the file anymore. I've merged your changes into the Emacs repository: * cedet/semantic/bovine/c.el (semantic-c-debug-mode-init) (semantic-c-debug-mode-init-pch): New functions. (semantic-c-debug-mode-init-last-mode): New var. (semantic-c-parse-lexical-token): Use them. * cedet/semantic/lex-spp.el (semantic-lex-spp-anlyzer-do-replace): When extracting the argument list, limit only by point-max. I assume it's the lex-spp change you're referring to. However, the bug has not gone away for me: `C-c , j window [TAB]' in xdisp.c still brings up "window" as the only completion.