From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#4929: 23.1.50; failed to access file inside zip archive when using tramp. Date: Sun, 15 Nov 2009 14:57:34 +0100 Message-ID: <87hbsvzy9d.fsf@gmx.de> References: Reply-To: Michael Albinus , 4929@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1258294070 31974 80.91.229.12 (15 Nov 2009 14:07:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Nov 2009 14:07:50 +0000 (UTC) Cc: 4929@emacsbugs.donarmstrong.com To: "Gideon Stupp \(gstupp\)" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 15 15:07:42 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N9flU-0008Dz-2j for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Nov 2009 15:07:40 +0100 Original-Received: from localhost ([127.0.0.1]:56904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9flT-0007pN-IG for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Nov 2009 09:07:39 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9flG-0007jU-OO for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2009 09:07:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9flC-0007fB-QZ for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2009 09:07:26 -0500 Original-Received: from [199.232.76.173] (port=43910 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9flC-0007f4-NJ for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2009 09:07:22 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54719) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N9flC-0006Xd-0X for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2009 09:07:22 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAFE7KKh014016; Sun, 15 Nov 2009 06:07:20 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAFE54Na013124; Sun, 15 Nov 2009 06:05:04 -0800 Resent-Date: Sun, 15 Nov 2009 06:05:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Michael Albinus Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 15 Nov 2009 14:05:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4929 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4929-submit@emacsbugs.donarmstrong.com id=B4929.125829346312445 (code B ref 4929); Sun, 15 Nov 2009 14:05:04 +0000 Original-Received: (at 4929) by emacsbugs.donarmstrong.com; 15 Nov 2009 13:57:43 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with SMTP id nAFDveu0012442 for <4929@emacsbugs.donarmstrong.com>; Sun, 15 Nov 2009 05:57:42 -0800 Original-Received: (qmail invoked by alias); 15 Nov 2009 13:57:34 -0000 Original-Received: from p57A20CDC.dip0.t-ipconnect.de (EHLO arthur.local) [87.162.12.220] by mail.gmx.net (mp021) with SMTP; 15 Nov 2009 14:57:34 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18XHWpwhakXAelqWiFMDpEpq6ZVNqZE/Hq189GsCr wSccObPybxwGGc In-Reply-To: (Gideon Stupp's message of "Sun, 15 Nov 2009 11:35:54 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.63 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sun, 15 Nov 2009 09:07:26 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32626 Archived-At: --=-=-= "Gideon Stupp (gstupp)" writes: > 1. Viewed zip archive with tramp - worked fine. > "/scp:xxxx:/tmp/my.zip" > 2. Pressed on one of the files and got "Opening output file: no > such file or directory, /tmp/archive.tmp3488-Qf/arc-mode.3488_Ky" > error. I've fixed this in the trunk with the appended patch. Could you, please, check whether it works for you? Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment *** /tmp/ediff5666akT 2009-11-15 14:56:12.000000000 +0100 --- /home/albinus/src/emacs/lisp/arc-mode.el 2009-11-15 14:43:00.000000000 +0100 *************** *** 818,832 **** file by that name already exists in DIR, a unique new name is generated using `make-temp-file', and the generated name is returned." (let ((fullname (expand-file-name fname dir)) ! (alien (string-match file-name-invalid-regexp fname))) ! (if (or alien (file-exists-p fullname)) ! (make-temp-file (expand-file-name (if (if (fboundp 'msdos-long-file-names) (not (msdos-long-file-names))) "am" "arc-mode.") ! dir)) fullname))) (defun archive-maybe-copy (archive) --- 818,839 ---- file by that name already exists in DIR, a unique new name is generated using `make-temp-file', and the generated name is returned." (let ((fullname (expand-file-name fname dir)) ! (alien (string-match file-name-invalid-regexp fname)) ! (tmpfile (expand-file-name (if (if (fboundp 'msdos-long-file-names) (not (msdos-long-file-names))) "am" "arc-mode.") ! dir))) ! (if (or alien (file-exists-p fullname)) ! (progn ! ;; Maked sure all the leading directories in ! ;; archive-local-name exist under archive-tmpdir, so that ! ;; the directory structure recorded in the archive is ! ;; reconstructed in the temporary directory. ! (make-directory (file-name-directory tmpfile) t) ! (make-temp-file tmpfile)) fullname))) (defun archive-maybe-copy (archive) *************** *** 843,853 **** archive))) (setq archive-local-name (archive-unique-fname archive-name archive-tmpdir)) - ;; Maked sure all the leading directories in - ;; archive-local-name exist under archive-tmpdir, so that - ;; the directory structure recorded in the archive is - ;; reconstructed in the temporary directory. - (make-directory (file-name-directory archive-local-name) t) (save-restriction (widen) (write-region start (point-max) archive-local-name nil 'nomessage)) --- 850,855 ---- --=-=-=--