all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: "Gideon Stupp \(gstupp\)" <gstupp@cisco.com>
Cc: 4929@emacsbugs.donarmstrong.com
Subject: bug#4929: 23.1.50; failed to access file inside zip archive when using tramp.
Date: Sun, 15 Nov 2009 14:57:34 +0100	[thread overview]
Message-ID: <87hbsvzy9d.fsf@gmx.de> (raw)
In-Reply-To: <F1A8D3F1CBD5D24286CFABABAAB27786A12D98@XMB-AMS-112.cisco.com> (Gideon Stupp's message of "Sun, 15 Nov 2009 11:35:54 +0100")

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

"Gideon Stupp (gstupp)" <gstupp@cisco.com> writes:

> 1. Viewed zip archive with tramp - worked fine.
>    "/scp:xxxx:/tmp/my.zip"
> 2. Pressed <ENTER> on one of the files and got "Opening output file: no
>    such file or directory, /tmp/archive.tmp3488-Qf/arc-mode.3488_Ky"
> error.

I've fixed this in the trunk with the appended patch. Could you, please,
check whether it works for you?

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2095 bytes --]

*** /tmp/ediff5666akT	2009-11-15 14:56:12.000000000 +0100
--- /home/albinus/src/emacs/lisp/arc-mode.el	2009-11-15 14:43:00.000000000 +0100
***************
*** 818,832 ****
  file by that name already exists in DIR, a unique new name is generated
  using `make-temp-file', and the generated name is returned."
    (let ((fullname (expand-file-name fname dir))
! 	(alien (string-match file-name-invalid-regexp fname)))
!     (if (or alien (file-exists-p fullname))
! 	(make-temp-file
  	 (expand-file-name
  	  (if (if (fboundp 'msdos-long-file-names)
  		  (not (msdos-long-file-names)))
  	      "am"
  	    "arc-mode.")
! 	  dir))
        fullname)))
  
  (defun archive-maybe-copy (archive)
--- 818,839 ----
  file by that name already exists in DIR, a unique new name is generated
  using `make-temp-file', and the generated name is returned."
    (let ((fullname (expand-file-name fname dir))
! 	(alien (string-match file-name-invalid-regexp fname))
! 	(tmpfile
  	 (expand-file-name
  	  (if (if (fboundp 'msdos-long-file-names)
  		  (not (msdos-long-file-names)))
  	      "am"
  	    "arc-mode.")
! 	  dir)))
!     (if (or alien (file-exists-p fullname))
! 	(progn
! 	  ;; Maked sure all the leading directories in
! 	  ;; archive-local-name exist under archive-tmpdir, so that
! 	  ;; the directory structure recorded in the archive is
! 	  ;; reconstructed in the temporary directory.
! 	  (make-directory (file-name-directory tmpfile) t)
! 	  (make-temp-file tmpfile))
        fullname)))
  
  (defun archive-maybe-copy (archive)
***************
*** 843,853 ****
  		   archive)))
  	  (setq archive-local-name
  		(archive-unique-fname archive-name archive-tmpdir))
- 	  ;; Maked sure all the leading directories in
- 	  ;; archive-local-name exist under archive-tmpdir, so that
- 	  ;; the directory structure recorded in the archive is
- 	  ;; reconstructed in the temporary directory.
- 	  (make-directory (file-name-directory archive-local-name) t)
  	  (save-restriction
  	    (widen)
  	    (write-region start (point-max) archive-local-name nil 'nomessage))
--- 850,855 ----

  reply	other threads:[~2009-11-15 13:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87bpj0dlvp.fsf@gmx.de>
2009-11-15 10:35 ` bug#4929: 23.1.50; failed to access file inside zip archive when using tramp Gideon Stupp (gstupp)
2009-11-15 13:57   ` Michael Albinus [this message]
2009-11-18 12:25     ` Gideon Stupp (gstupp)
2009-11-18 13:10   ` bug#4929: marked as done (23.1.50; failed to access file inside zip archive when using tramp.) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbsvzy9d.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=4929@emacsbugs.donarmstrong.com \
    --cc=gstupp@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.