all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Lennart Borgman <lennart.borgman@gmail.com>
Cc: 6223@debbugs.gnu.org
Subject: bug#6223: isearch-yank-string should use isearch-process-string
Date: Thu, 20 May 2010 03:16:01 +0300	[thread overview]
Message-ID: <87hbm38m2m.fsf@mail.jurta.org> (raw)
In-Reply-To: <AANLkTinIjXH1xApi_JQIAEA22E4u6KxB_zsErcBZX3D6@mail.gmail.com> (Lennart Borgman's message of "Thu, 20 May 2010 01:38:54 +0200")

> to be consistent IMO.

Thanks for the suggestion.  I see no problem with this change:

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el	2010-04-16 01:30:37 +0000
+++ lisp/isearch.el	2010-05-20 00:14:58 +0000
@@ -1476,14 +1476,10 @@ (defun isearch-yank-string (string)
 	   (eq 'not-yanks search-upper-case))
       (setq string (downcase string)))
   (if isearch-regexp (setq string (regexp-quote string)))
-  (setq isearch-string (concat isearch-string string)
-	isearch-message
-	(concat isearch-message
-		(mapconcat 'isearch-text-char-description
-			   string ""))
-	;; Don't move cursor in reverse search.
-	isearch-yank-flag t)
-  (isearch-search-and-update))
+  ;; Don't move cursor in reverse search.
+  (setq isearch-yank-flag t)
+  (isearch-process-search-string
+   string (mapconcat 'isearch-text-char-description string "")))
 
 (defun isearch-yank-kill ()
   "Pull string from kill ring into search string."

-- 
Juri Linkov
http://www.jurta.org/emacs/





  reply	other threads:[~2010-05-20  0:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 23:38 bug#6223: isearch-yank-string should use isearch-process-string Lennart Borgman
2010-05-20  0:16 ` Juri Linkov [this message]
2010-05-20 21:52   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbm38m2m.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=6223@debbugs.gnu.org \
    --cc=lennart.borgman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.