From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#5270: [PATCH] * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs) Insert thumbnails before file names of marked files in the dired buffer. Date: Tue, 25 May 2010 18:59:48 +0200 Organization: ThierryVolpiatto Message-ID: <87hblvrk6z.fsf@tux.homenetwork> References: <878w79vzxw.fsf@tux.homenetwork> <87typwv5lr.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1274808468 1237 80.91.229.12 (25 May 2010 17:27:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 25 May 2010 17:27:48 +0000 (UTC) Cc: 5270@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 25 19:27:46 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OGxum-0004wi-K7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 May 2010 19:27:46 +0200 Original-Received: from localhost ([127.0.0.1]:34961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGxuj-0000o6-LO for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 May 2010 13:27:37 -0400 Original-Received: from [140.186.70.92] (port=58672 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGxuU-0000fA-45 for bug-gnu-emacs@gnu.org; Tue, 25 May 2010 13:27:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGxuR-0000cb-9e for bug-gnu-emacs@gnu.org; Tue, 25 May 2010 13:27:20 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56610) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGxuR-0000cX-7g for bug-gnu-emacs@gnu.org; Tue, 25 May 2010 13:27:19 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OGxXt-0005yG-OR; Tue, 25 May 2010 13:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2010 17:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5270 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5270-submit@debbugs.gnu.org id=B5270.127480700122941 (code B ref 5270); Tue, 25 May 2010 17:04:01 +0000 Original-Received: (at 5270) by debbugs.gnu.org; 25 May 2010 17:03:21 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGxXE-0005xy-7B for submit@debbugs.gnu.org; Tue, 25 May 2010 13:03:20 -0400 Original-Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGxXB-0005xt-WC for 5270@debbugs.gnu.org; Tue, 25 May 2010 13:03:18 -0400 Original-Received: by wye20 with SMTP id 20so1492358wye.3 for <5270@debbugs.gnu.org>; Tue, 25 May 2010 10:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject :organization:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=0GcLM/WX5GiM7DuNecC3vLdUFaxFBRUGm3TCSGnL2yw=; b=anm6zh+LJYEGoNYrX9XUk9Gm3YJUegO+oGwEmTqGUUKvLpwW2XD0nfxnWpzPpG9bTK jCqUHkGI6oLihtwZzcay285tL+shy/X3wz9B/znGW5uISdjCYSmhbBiJ9yvLY9WvZA0z lyTdYI2zv8UDBtZ0YaNPNG0zKb3UsKCcHlemk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=tvawQgljDNiOCaCAZfcJTAYHL4AExPctCzqbSXPSXiStMHstuoW9jV5EKndOY0cDVE jJ8OeBnK+6ZHy1KhULTgqzWOymb2vj1XcUrnI56NIvOcm4wht507r5hrqx+vpXO4xUNe w/DGACx71HugHixee322WCFhzPR7sZlyq7MgY= Original-Received: by 10.227.133.138 with SMTP id f10mr835546wbt.37.1274806989113; Tue, 25 May 2010 10:03:09 -0700 (PDT) Original-Received: from tux.homenetwork (170.77.197-77.rev.gaoland.net [77.197.77.170]) by mx.google.com with ESMTPS id t20sm40681477wbc.4.2010.05.25.10.03.07 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 25 May 2010 10:03:08 -0700 (PDT) In-Reply-To: <87typwv5lr.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 25 May 2010 18:49:04 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 25 May 2010 13:04:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37266 Archived-At: Juri Linkov writes: >>> Thierry, could you please send the latest version of your patch here >>> to 5270@debbugs.gnu.org? It seems a good change to install to Emacs. >> >> changeset: 108790:edb0d0e61eb8 >> tag: qtip >> tag: patch-r108790 >> tag: tip >> tag: qbase >> user: Thierry Volpiatto >> date: Mon May 24 21:40:52 2010 +0200 >> summary: * lisp/image-dired.el (image-dired-dired-insert-marked-thumbs) >> Insert thumbnails before file names of marked files in the dired buffer. > > Thanks. I think your patch should be committed now with two small changes: > > 1. To make it compatible with other Dired commands, use the interactive > spec (interactive "P") instead of (interactive "p"). > And also remove the line `(when (eq arg 1) (setq arg nil))' because > `dired-map-over-marks' already takes care of the prefix argument. Agree, that's better. > 2. Create a new function `image-dired-dired-toggle-marked-thumbs' > from your changes and re-bind it to "\C-t\C-t" in dired.el > because this is a better name for changed functionality. > The current function `image-dired-dired-insert-marked-thumbs' > could be obsoleted later. Yes we already talk about using "toggle" as name and i completely forget that, so yes it is better to rename to `image-dired-dired-toggle-marked-thumbs'. I think also the old function can safely be removed. > I tried your patch with these small changes, and it is much better > than the current `image-dired-dired-insert-marked-thumbs'. Thanks, feel free also to write docstring in better english if something is incorrect.(E.g Explaining better how to use (+/-)prefix arg maybe). -- Thierry Volpiatto Gpg key: http://pgp.mit.edu/