From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.devel Subject: Re: Base patch for bug #5975 (bookmarking from Gnus Article buffer). Date: Wed, 14 Jul 2010 11:32:30 -0400 Message-ID: <87hbk2axkh.fsf@kslab.red-bean.com> References: <87y6dydn6q.fsf@tux.homenetwork> <201006292126.15409.tassilo@member.fsf.org> <87iq51ehnv.fsf@tux.homenetwork> <201006292210.43121.tassilo@member.fsf.org> <87eifpegqx.fsf@tux.homenetwork> <87k4ozdq6b.fsf_-_@red-bean.com> <87d3urdppj.fsf@red-bean.com> <87sk3mbh60.fsf@tux.homenetwork> Reply-To: Karl Fogel NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1279121563 2325 80.91.229.12 (14 Jul 2010 15:32:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 14 Jul 2010 15:32:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 14 17:32:42 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ3wv-0006r2-AX for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 17:32:41 +0200 Original-Received: from localhost ([127.0.0.1]:42369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ3wt-0002tn-Rk for ged-emacs-devel@m.gmane.org; Wed, 14 Jul 2010 11:32:39 -0400 Original-Received: from [140.186.70.92] (port=54964 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OZ3wk-0002ti-5h for emacs-devel@gnu.org; Wed, 14 Jul 2010 11:32:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OZ3wi-0002KY-Ma for emacs-devel@gnu.org; Wed, 14 Jul 2010 11:32:30 -0400 Original-Received: from osh-net-219-98.onshore.net ([66.146.219.98]:38027 helo=sanpietro.red-bean.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OZ3wi-0002KU-KE for emacs-devel@gnu.org; Wed, 14 Jul 2010 11:32:28 -0400 Original-Received: from localhost ([127.0.0.1]:40729 helo=kslab.red-bean.com ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.72) (envelope-from ) id 1OZ3wi-00051Z-B4; Wed, 14 Jul 2010 10:32:28 -0500 In-Reply-To: <87sk3mbh60.fsf@tux.homenetwork> (Thierry Volpiatto's message of "Wed, 14 Jul 2010 10:29:11 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:127293 Archived-At: Thierry Volpiatto writes: >Karl Fogel writes: >> Karl Fogel writes: >>>Just for reference, the current (preparatory) patch is below. I will >>>follow up separately with the gnus/* patch, so it's in the archives. >> >> Here's that patch (still needs the C-w fix referred to in the bug, though). > >BTW, generally for all contributors patchs: > >if patch WORK and is basically correct and is accepted of course, why >not applying patch as it is and modifying as Emacs developpers like in >one or more little other commits. Yes. The only reason I delayed was because I wasn't sure about making those non-trivial modifications to Gnus. However, no one has said it's a problem, and the files are in our tree -- I guess I'll commit the next patches, and then we'll fix the C-w problem afterwards. -Karl