bug#6660: xassert failure on make custom-deps

bug#6660: xassert failure on make custom-deps

[Juanma Barranquero]

Package: emacs
Severity: important
Version: 24.0.50

After

  cd lisp
  make custom-deps

or just while bootstrapping, I get a (repeatable) xassert failure on
dispnew.c:adjust_frame_glyphs_for_frame_redisplay.

    Juanma


Program received signal SIGTRAP, Trace/breakpoint trap.
[Switching to Thread 4116.0x1294]
0x757522a2 in KERNELBASE!DeleteAce () from C:\Windows\syswow64\KernelBase.dll
(gdb) bt
#0  0x757522a2 in KERNELBASE!DeleteAce () from
C:\Windows\syswow64\KernelBase.dll
#1  0x0132225d in w32_abort () at w32fns.c:7256
#2  0x012114cd in adjust_frame_glyphs_for_frame_redisplay
(f=0x2ec1c00) at dispnew.c:2254
#3  0x01210bf3 in adjust_frame_glyphs (f=0x2ec1c00) at dispnew.c:2051
#4  0x0121070f in adjust_glyphs (f=0x2ec1c00) at dispnew.c:1994
#5  0x011c7cff in Fsplit_window (window=49027589, size=48908314,
horizontal=48908314) at window.c:3936
#6  0x0103ace4 in Ffuncall (nargs=3, args=0x88dea0) at eval.c:2996
#7  0x011f487c in Fbyte_code (bytestr=20805849, vector=20805973,
maxdepth=28) at bytecode.c:679
#8  0x0103b90d in funcall_lambda (fun=20805813, nargs=0,
arg_vector=0x88e164) at eval.c:3172
#9  0x0103b12d in Ffuncall (nargs=1, args=0x88e160) at eval.c:3036
#10 0x011f487c in Fbyte_code (bytestr=20802889, vector=20803013,
maxdepth=16) at bytecode.c:679
#11 0x0103b90d in funcall_lambda (fun=20802861, nargs=1,
arg_vector=0x88e424) at eval.c:3172
#12 0x0103b12d in Ffuncall (nargs=2, args=0x88e420) at eval.c:3036
#13 0x01038a76 in Feval (form=20803710) at eval.c:2328
#14 0x01036a18 in internal_lisp_condition_case (var=48908314,
bodyform=20803710, handlers=20214990) at eval.c:1410
#15 0x011f550e in Fbyte_code (bytestr=20803593, vector=20803661,
maxdepth=12) at bytecode.c:869
#16 0x0103b90d in funcall_lambda (fun=20803565, nargs=1,
arg_vector=0x88e874) at eval.c:3172
#17 0x0103b12d in Ffuncall (nargs=2, args=0x88e870) at eval.c:3036
#18 0x011f487c in Fbyte_code (bytestr=20804737, vector=20804989,
maxdepth=20) at bytecode.c:679
#19 0x0103b90d in funcall_lambda (fun=20804693, nargs=2,
arg_vector=0x88eb34) at eval.c:3172
#20 0x0103b12d in Ffuncall (nargs=3, args=0x88eb30) at eval.c:3036
#21 0x011f487c in Fbyte_code (bytestr=20805569, vector=20805669,
maxdepth=20) at bytecode.c:679
#22 0x0103b90d in funcall_lambda (fun=20805517, nargs=3,
arg_vector=0x88edf4) at eval.c:3172
#23 0x0103b12d in Ffuncall (nargs=4, args=0x88edf0) at eval.c:3036
#24 0x011f487c in Fbyte_code (bytestr=20344697, vector=20344757,
maxdepth=16) at bytecode.c:679
#25 0x0103b90d in funcall_lambda (fun=20344653, nargs=1,
arg_vector=0x88f0a4) at eval.c:3172
#26 0x0103b12d in Ffuncall (nargs=2, args=0x88f0a0) at eval.c:3036
#27 0x011f487c in Fbyte_code (bytestr=20345969, vector=20346029,
maxdepth=24) at bytecode.c:679
#28 0x0103b90d in funcall_lambda (fun=20345941, nargs=1,
arg_vector=0x88f364) at eval.c:3172
#29 0x0103b12d in Ffuncall (nargs=2, args=0x88f360) at eval.c:3036
#30 0x011f487c in Fbyte_code (bytestr=20494401, vector=20494885,
maxdepth=40) at bytecode.c:679
#31 0x0103b90d in funcall_lambda (fun=20494373, nargs=1,
arg_vector=0x88f634) at eval.c:3172
#32 0x0103b12d in Ffuncall (nargs=2, args=0x88f630) at eval.c:3036
#33 0x011f487c in Fbyte_code (bytestr=20476833, vector=20477797,
maxdepth=28) at bytecode.c:679
#34 0x0103b90d in funcall_lambda (fun=20476813, nargs=0,
arg_vector=0x88f8f4) at eval.c:3172
#35 0x0103b12d in Ffuncall (nargs=1, args=0x88f8f0) at eval.c:3036
#36 0x011f487c in Fbyte_code (bytestr=20473489, vector=20473709,
maxdepth=24) at bytecode.c:679
#37 0x0103b90d in funcall_lambda (fun=20473469, nargs=0,
arg_vector=0x88fb10) at eval.c:3172
#38 0x0103b354 in apply_lambda (fun=20473469, args=48908314,
eval_flag=1) at eval.c:3099
#39 0x01039229 in Feval (form=49182734) at eval.c:2397
#40 0x0100712b in top_level_2 () at keyboard.c:1350
#41 0x01036afa in internal_condition_case (bfun=0x1007118
<top_level_2>, handlers=48965874, hfun=0x1006c2c <cmd_error>) at
eval.c:1463
#42 0x0100715f in top_level_1 (ignore=48908314) at keyboard.c:1358
#43 0x01036579 in internal_catch (tag=48964042, func=0x100712d
<top_level_1>, arg=48908314) at eval.c:1207
#44 0x0100709d in command_loop () at keyboard.c:1313
#45 0x01006338 in recursive_edit_1 () at keyboard.c:943
#46 0x01006852 in Frecursive_edit () at keyboard.c:1005
#47 0x01002bdd in main (argc=40, argv=0xae1438) at emacs.c:1778

Lisp Backtrace:
"split-window" (0x88dea4)
"split-window-vertically" (0x88e164)
"split-window-sensibly" (0x88e424)
"funcall" (0x88e420)
"window--try-to-split-window" (0x88e874)
"display-buffer" (0x88eb34)
"pop-to-buffer" (0x88edf4)
"switch-to-buffer-other-window" (0x88f0a4)
"find-file-other-window" (0x88f364)
"command-line-1" (0x88f634)
"command-line" (0x88f8f4)
"normal-top-level" (0x88fb10)
(gdb) frame 2
#2  0x012114cd in adjust_frame_glyphs_for_frame_redisplay
(f=0x2ec1c00) at dispnew.c:2254
2254          xassert (matrix_dim.width == FRAME_COLS (f)
(gdb) p FRAME_COLS(f)
$1 = 10
(gdb) p FRAME_LINES(f)
$2 = 10
(gdb) p matrix_dim
$3 = {
  width = 10,
  height = 11
}
(gdb) p *f
$4 = {
  size = 1073742869,
  next = 0x2ea9a00,
  name = 20180041,
  icon_name = 48908314,
  title = 48908314,
  focus_frame = 48908314,
  root_window = 53313029,
  selected_window = 49027589,
  minibuffer_window = 49027077,
  param_alist = 48908314,
  scroll_bars = 48908314,
  condemned_scroll_bars = 48908314,
  menu_bar_items = 48908314,
  face_alist = 78455814,
  menu_bar_vector = 48908314,
  buffer_predicate = 48908314,
  buffer_list = 80921750,
  buried_buffer_list = 48908314,
  menu_bar_window = 48908314,
  tool_bar_window = 48908314,
  tool_bar_items = 48908314,
  desired_tool_bar_string = 48908314,
  current_tool_bar_string = 48908314,
  face_cache = 0x2fe4ee0,
  menu_bar_items_used = 0,
  namebuf = 0x0,
  current_pool = 0x2f51a20,
  desired_pool = 0x2f51d40,
  desired_matrix = 0x4cfc400,
  current_matrix = 0x4d11000,
  glyphs_initialized_p = 0,
  resized_p = 0,
  force_flush_display_p = 0,
  default_face_done_p = 0,
  already_hscrolled_p = 0,
  updated_p = 0,
  minimize_tool_bar_window_p = 0,
  tool_bar_lines = 0,
  n_tool_bar_rows = 0,
  n_tool_bar_items = 0,
  decode_mode_spec_buffer = 0x0,
  insert_line_cost = 0x0,
  delete_line_cost = 0x0,
  insert_n_lines_cost = 0x0,
  delete_n_lines_cost = 0x0,
  text_lines = 10,
  text_cols = 10,
  total_lines = 0,
  total_cols = 10,
  new_text_lines = 0,
  new_text_cols = 0,
  left_pos = 0,
  top_pos = 0,
  pixel_height = 0,
  pixel_width = 0,
  resx = 0,
  resy = 0,
  x_pixels_diff = 0,
  y_pixels_diff = 0,
  win_gravity = 0,
  size_hint_flags = 0,
  border_width = 0,
  internal_border_width = 0,
  column_width = 1,
  space_width = 0,
  line_height = 1,
  output_method = output_initial,
  terminal = 0x2ea9a00,
  output_data = {
    tty = 0x0,
    x = 0x0,
    w32 = 0x0,
    ns = 0x0,
    nothing = 0
  },
  font_driver_list = 0x0,
  font_data_list = 0x0,
  fringe_cols = 0,
  left_fringe_width = 0,
  right_fringe_width = 0,
  want_fullscreen = FULLSCREEN_NONE,
  menu_bar_lines = 1,
  external_menu_bar = 0,
  display_preempted = 0 '\000',
  visible = 1 '\001',
  iconified = 0 '\000',
  async_visible = 1 '\001',
  async_iconified = 0 '\000',
  garbaged = 1 '\001',
  has_minibuffer = 1 '\001',
  wants_modeline = 1 '\001',
  can_have_scroll_bars = 0 '\000',
  auto_raise = 0 '\000',
  auto_lower = 0 '\000',
  no_split = 0 '\000',
  explicit_name = 0 '\000',
  window_sizes_changed = 1 '\001',
  mouse_moved = 0 '\000',
  pointer_invisible = 0 '\000',
  vertical_scroll_bar_type = vertical_scroll_bar_none,
  desired_cursor = FILLED_BOX_CURSOR,
  cursor_width = 0,
  blink_off_cursor = FILLED_BOX_CURSOR,
  blink_off_cursor_width = 0,
  message_buf = 0x0,
  scroll_bottom_vpos = 0,
  config_scroll_bar_width = 0,
  config_scroll_bar_cols = 0,
  scroll_bar_actual_width = 0,
  cost_calculation_baud_rate = 0,
  alpha = {0, 0},
  gamma = 0,
  extra_line_spacing = 0,
  background_pixel = 4294967293,
  foreground_pixel = 4294967294
}

bug#6660: xassert failure on make custom-deps

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 17 Jul 2010 02:38:22 +0200
> Cc: 
> 
> Package: emacs
> Severity: important
> Version: 24.0.50
> 
> After
> 
>   cd lisp
>   make custom-deps
> 
> or just while bootstrapping, I get a (repeatable) xassert failure on
> dispnew.c:adjust_frame_glyphs_for_frame_redisplay.

Confirmed.  "bzr bisect" blames this commit:

  cyd@stupidchicken.com-20100710185647-l4ex7uy98klo3a57
  revno: 100769
  committer: Chong Yidong <cyd@stupidchicken.com>
  branch nick: trunk
  timestamp: Sat 2010-07-10 14:56:47 -0400
  message:
    Adapt terminal frames to latest menu-bar changes.

    * frame.c (make_frame): Initialize menu_bar_lines and
    tool_bar_lines members.
    (make_initial_frame, make_terminal_frame): Initialize
    menu_bar_lines using value of menu-bar-mode.

    * msdos.c (IT_set_frame_parameters): Don't set menu-bar-lines.

The fact that matrix_dim.height and FRAME_LINES (f) differ by one
seems to agree with the diagnosis.

Can someone see if the same happens on GNU/Linux (you will need to
compile with "-DENABLE_CHECKING -DXASSERTS=1").

bug#6660: xassert failure on make custom-deps

[Juanma Barranquero]

On Sat, Jul 17, 2010 at 12:07, Eli Zaretskii <eliz@gnu.org> wrote:

> (you will need to
> compile with "-DENABLE_CHECKING -DXASSERTS=1").

We should recommend that for developers, I think.

    Juanma

bug#6660: xassert failure on make custom-deps

[Juanma Barranquero]

On Sat, Jul 17, 2010 at 12:07, Eli Zaretskii <eliz@gnu.org> wrote:

> Can someone see if the same happens on GNU/Linux

Apparently, yes:

  Generating /home/juanma/repo/trunk/lisp/cus-load.el...
  Loading vc-bzr...
  Saving file /home/juanma/repo/trunk/lisp/cus-load.el...
  Wrote /home/juanma/repo/trunk/lisp/cus-load.el
  Generating /home/juanma/repo/trunk/lisp/cus-load.el...done
  Fatal error (6)Aborted
  make[3]: *** [custom-deps] Error 134

That's on

  ubuntu% uname -a
  Linux ubuntu 2.6.32-23-generic #37-Ubuntu SMP Fri Jun 11 07:54:58
UTC 2010 i686 GNU/Linux


    Juanma

bug#6660: xassert failure on make custom-deps

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 17 Jul 2010 15:02:37 +0200
> Cc: 6660@debbugs.gnu.org
> 
> On Sat, Jul 17, 2010 at 12:07, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > (you will need to
> > compile with "-DENABLE_CHECKING -DXASSERTS=1").
> 
> We should recommend that for developers, I think.

How about turning it on by default in nt/configure.bat, when --no-opt
was specified?  I'm tired of editing src/makefile by hand.

bug#6660: xassert failure on make custom-deps

[Juanma Barranquero]

On Sat, Jul 17, 2010 at 17:30, Eli Zaretskii <eliz@gnu.org> wrote:

> How about turning it on by default in nt/configure.bat, when --no-opt
> was specified?

I'm all for it, but it has a small, though non-negligible impact on
performance. Are the official binary builds for Windows optimized or
non-optimized?

    Juanma

bug#6660: xassert failure on make custom-deps

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 17 Jul 2010 18:29:52 +0200
> Cc: 6660@debbugs.gnu.org
> 
> On Sat, Jul 17, 2010 at 17:30, Eli Zaretskii <eliz@gnu.org> wrote:
> 
> > How about turning it on by default in nt/configure.bat, when --no-opt
> > was specified?
> 
> I'm all for it, but it has a small, though non-negligible impact on
> performance. Are the official binary builds for Windows optimized or
> non-optimized?

I don't know.

Perhaps we should simply add another switch to configure.bat, like,
for example, --enable-checking.  That would keep everyone happy.

bug#6660: xassert failure on make custom-deps

[Chong Yidong]

Eli Zaretskii <eliz@gnu.org> writes:

>>   cd lisp
>>   make custom-deps
>> 
>> or just while bootstrapping, I get a (repeatable) xassert failure on
>> dispnew.c:adjust_frame_glyphs_for_frame_redisplay.
>
> Confirmed.  "bzr bisect" blames this commit:

Thanks.  I've checked in a fix.