all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 6636@debbugs.gnu.org
Subject: bug#6636: 24.0.50; special dired feature confuse all dired commands.
Date: Sun, 18 Jul 2010 07:24:05 +0200	[thread overview]
Message-ID: <87hbjx4b2i.fsf@tux.homenetwork> (raw)
In-Reply-To: <87bpa56dqz.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 17 Jul 2010 16:43:16 -0400")

Chong Yidong <cyd@stupidchicken.com> writes:

> "Drew Adams" <drew.adams@oracle.com> writes:
>
>> The is in `dired-buffers-for-dir'.  It has this code:
>>
>> (file-name-non-directory dired-directory)
>>
>> This is wrong. `dired-directory' has every right to be a cons, as it
>> is in this case.
>>
>> Function `dired-buffers-for-dir' was introduced in 23.1, creating this
>> regression wrt Emacs 22.3 and prior releases.
>
> I see the bug, but I don't know where you got the idea that this is a
> regression.  dired-buffers-for-dir has been unchanged since 1997 (except
> for the removal one unused local variable, which does not affect the
> present behavior bug).
>
> I'll check in a fix.

Nice, 
also it would be good to use in many places in emacs something
like:

,----
| (defun anything-c-current-directory ()
|   "Return current-directory name at point.
| Useful in dired buffers when there is inserted subdirs."
|   (if (eq major-mode 'dired-mode)
|       (dired-current-directory)
|       default-directory))
`----

instead of just `default-directory'

(e.g vc-dir, even if i don't use it)

-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 





      parent reply	other threads:[~2010-07-18  5:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-15  7:34 bug#6636: 24.0.50; special dired feature confuse all dired commands Thierry Volpiatto
2010-07-15 18:16 ` Drew Adams
2010-07-17 20:43   ` Chong Yidong
2010-07-17 21:06     ` Drew Adams
2010-07-18  5:24     ` Thierry Volpiatto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbjx4b2i.fsf@tux.homenetwork \
    --to=thierry.volpiatto@gmail.com \
    --cc=6636@debbugs.gnu.org \
    --cc=cyd@stupidchicken.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.