repeat-complex-command too complex

repeat-complex-command too complex

[despen]

I  often need  to redo  query-replace, usually with slightly different
arguments.

I first do M-% aaa bbb.

Then I want to repeat the command to maybe replace xxx by bbb.

I do C-x ESC ESC (repeat-complex-command)

I then see at least 2 lines in the mini-buffer reading:

redo: (query-replace "aaa" "bbb" nil (if
 (and transient-mark-mode mark-active)
 (region-beginning))
 (if (and transient-mark-mode mark-active) (region-end)))

Why is all that ?JUNK? there.  It's not so easy to get back to
the "bbb" part and change it.

I'd really like to see something like:

redo: (query-replace "aaa" "bbb")

I tried this with emacs -q and got the same results.

Re: repeat-complex-command too complex

[Barry Margolin]

In article <icmxq1m3cc.fsf@verizon.net>, despen@verizon.net wrote:

> It's pretty unfortunate.  I actually have repeat-complex-command
> bound to a key and use it a lot.  Plus I never use transient mark
> mode.  It's too visually disturbing.
> 
> Thanks.

(defun my-query-replace (from-string to-string)
  (interactive "sReplace: \nsWith: ")
  (query-replace from-string to-string))

Then bind M-% to my-query-replace.

-- 
Barry Margolin, barmar@alum.mit.edu
Arlington, MA
*** PLEASE post questions in newsgroups, not directly to me ***
*** PLEASE don't copy me on replies, I'll read them in the group ***

Re: repeat-complex-command too complex

[despen]

Barry Margolin <barmar@alum.mit.edu> writes:

> In article <icmxq1m3cc.fsf@verizon.net>, despen@verizon.net wrote:
>
>> It's pretty unfortunate.  I actually have repeat-complex-command
>> bound to a key and use it a lot.  Plus I never use transient mark
>> mode.  It's too visually disturbing.
>> 
>> Thanks.
>
> (defun my-query-replace (from-string to-string)
>   (interactive "sReplace: \nsWith: ")
>   (query-replace from-string to-string))
>
> Then bind M-% to my-query-replace.

Have to admit, I tried to do that myself and failed.
My understanding of "interactive" is sadly lacking.
I think I have it now though.

Thanks!

Re: repeat-complex-command too complex

[Andreas Politz]

despen@verizon.net writes:

> Barry Margolin <barmar@alum.mit.edu> writes:
>
>> In article <icmxq1m3cc.fsf@verizon.net>, despen@verizon.net wrote:
>>
>>> It's pretty unfortunate.  I actually have repeat-complex-command
>>> bound to a key and use it a lot.  Plus I never use transient mark
>>> mode.  It's too visually disturbing.
>>> 
>>> Thanks.
>>
>> (defun my-query-replace (from-string to-string)
>>   (interactive "sReplace: \nsWith: ")
>>   (query-replace from-string to-string))
>>
>> Then bind M-% to my-query-replace.
>
> Have to admit, I tried to do that myself and failed.
> My understanding of "interactive" is sadly lacking.
> I think I have it now though.
>
> Thanks!

Changing the interactive spec with an advice is also an option.

(defadvice query-replace (before hack-interactive-spec activate)
  (interactive
   (let ((common
	  (query-replace-read-args
	   (concat "Replace"
		   (if current-prefix-arg " word" "")
		   " string")
	   nil)))
     (list (nth 0 common) (nth 1 common) (nth 2 common)))))

-ap