From: Michael Albinus <michael.albinus@gmx.de>
To: Jan Moringen <jan.moringen@uni-bielefeld.de>
Cc: emacs-devel@gnu.org
Subject: Re: DBus methods without name grabbing
Date: Mon, 10 Jan 2011 12:40:58 +0100 [thread overview]
Message-ID: <87hbdhugtx.fsf@gmx.de> (raw)
In-Reply-To: <24098_1294589394_ZZh0g1BtrpOWT.00_1294589334.2322.207.camel@gunhead> (Jan Moringen's message of "Sun, 09 Jan 2011 17:08:54 +0100")
Jan Moringen <jan.moringen@uni-bielefeld.de> writes:
> Hi Michael,
Hi Jan,
> sorry for the sloppy patch. I couldn't put as much time into it as I
> would have liked.
Don't worry. By this, I had something to comment :-)
>> > + (dbus-register-method
>> > + bus service path dbus-interface-properties "Set"
>> > + 'dbus-property-handler nil)
>> > +
>> > + ;; Register the name SERVICE with BUS.
>> > + (unless dont-register-service
>> > + (dbus-register-service bus service))
>>
>> I guess you mean t (or better 'dont-register) as last argument of the
>> dbus-register-method calls.
>
> I think it has to be t. The service is registered or not in the
> following call to `dbus-register-service' depending on
> `dont-register-service'.
I did not mean the value of `dont-register-service', but a symbol
`dont-register'. For better readability, one could use a symbol
describing what is meant with a non-nil value.
> I hope this increases the quality of the patch to bearable levels.
I have committed your patchset. Afterwards, I have applied some further
minor tweakings.
> Kind regards,
> Jan
Best regards, Michael.
next prev parent reply other threads:[~2011-01-10 11:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 21:06 DBus methods without name grabbing Jan Moringen
2011-01-03 12:55 ` Michael Albinus
2011-01-04 2:42 ` Jan Moringen
2011-01-04 10:10 ` Michael Albinus
2011-01-04 10:29 ` Jan Moringen
2011-01-04 13:09 ` Michael Albinus
2011-01-05 4:17 ` Jan Moringen
2011-01-05 11:45 ` Michael Albinus
2011-01-08 5:48 ` Jan Moringen
2011-01-09 9:42 ` Michael Albinus
2011-01-09 16:08 ` Jan Moringen
2011-01-10 11:40 ` Michael Albinus [this message]
[not found] ` <1294201048.2508.1.camel@gunhead>
2011-01-05 10:46 ` Jan Moringen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbdhugtx.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=jan.moringen@uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.