From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: bug in copy-directory Date: Sat, 12 Feb 2011 17:46:17 -0500 Message-ID: <87hbc8x45i.fsf@stupidchicken.com> References: <87ipxaidea.fsf@gmail.com> <87y65yyxfu.fsf@gmail.com> <87d3n8xkeq.fsf@gmail.com> <878vxw6r4m.fsf@gmx.de> <87pqr790b0.fsf@gmail.com> <87oc6r7gjc.fsf@gmx.de> <87ipwz8t92.fsf@gmail.com> <878vxt69k7.fsf@stupidchicken.com> <874o8hbc9q.fsf@gmx.de> <87y65txele.fsf@gmail.com> <87tyghxdgx.fsf@gmail.com> <87wrl98adj.fsf@stupidchicken.com> <87k4h7at1c.fsf@gmail.com> <87fwrvkm3y.fsf@gmx.de> <871v3eucjw.fsf@gmail.com> <87tyga86p0.fsf@stupidchicken.com> <8762spspeb.fsf@gmail.com> <87zkq1m461.fsf@stupidchicken.com> <87lj1krk7y.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297552285 28653 80.91.229.12 (12 Feb 2011 23:11:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 12 Feb 2011 23:11:25 +0000 (UTC) Cc: Michael Albinus , emacs-devel@gnu.org To: Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 13 00:11:19 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PoOcZ-0006vi-4y for ged-emacs-devel@m.gmane.org; Sun, 13 Feb 2011 00:11:19 +0100 Original-Received: from localhost ([127.0.0.1]:42389 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PoOPH-0005J7-SN for ged-emacs-devel@m.gmane.org; Sat, 12 Feb 2011 17:57:35 -0500 Original-Received: from [140.186.70.92] (port=39225 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PoOEV-0000gI-5X for emacs-devel@gnu.org; Sat, 12 Feb 2011 17:46:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PoOER-0000is-TQ for emacs-devel@gnu.org; Sat, 12 Feb 2011 17:46:24 -0500 Original-Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]:45057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PoOER-0000il-PH for emacs-devel@gnu.org; Sat, 12 Feb 2011 17:46:23 -0500 Original-Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1CMkKaL020001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 12 Feb 2011 17:46:20 -0500 Original-Received: by furball (Postfix, from userid 1000) id 9FEE71605B7; Sat, 12 Feb 2011 17:46:17 -0500 (EST) In-Reply-To: <87lj1krk7y.fsf@gmail.com> (Thierry Volpiatto's message of "Sat, 12 Feb 2011 22:55:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135958 Archived-At: Thierry Volpiatto writes: >> 1. I didn't apply the change to dired-aux.el. It doesn't seem to do the >> right thing. With that change patch, if I try to use the `C' command in >> Dired, I get an error. >> >> mkdir ~/a >> emacs ~/ >> [move point to a] >> C >> ~/b RET => error. > > To be sure: > b is a non--existing directory, right? Yep. >> 2. You have non-standard indentation settings which make your patches >> bigger than they should be, harder to read, and requires re-editing of >> the results before they can be committed. Stuff like this should not be > > I use cl indent, just apply patch and reindent. It's unreasonable to ask others to apply a patch, edit the results, and rediff just to read your patches. It defeats the purpose of diffs.