From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#8280: 24.0.50; ibuffer: "filters to filter group" broken Date: Sun, 14 Aug 2011 14:10:55 -0400 Message-ID: <87hb5jg8y8.fsf@stupidchicken.com> References: <87oc58h9nc.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1313345497 17061 80.91.229.12 (14 Aug 2011 18:11:37 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 14 Aug 2011 18:11:37 +0000 (UTC) Cc: 8280@debbugs.gnu.org, Noam Postavsky To: fourquet.d@gmail.com (=?UTF-8?Q?Rafa=C3=ABl?= Fourquet) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 14 20:11:32 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qsf9m-0002UH-JZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Aug 2011 20:11:30 +0200 Original-Received: from localhost ([::1]:60362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qsf9l-0003yF-TB for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Aug 2011 14:11:29 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qsf9i-0003xu-Iv for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2011 14:11:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qsf9h-0006MR-Mh for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2011 14:11:26 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qsf9h-0006MN-Jw for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2011 14:11:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QsfBF-0006Rc-SD; Sun, 14 Aug 2011 14:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2011 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8280 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8280-submit@debbugs.gnu.org id=B8280.131334556124727 (code B ref 8280); Sun, 14 Aug 2011 18:13:01 +0000 Original-Received: (at 8280) by debbugs.gnu.org; 14 Aug 2011 18:12:41 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QsfAs-0006Qk-MG for submit@debbugs.gnu.org; Sun, 14 Aug 2011 14:12:40 -0400 Original-Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QsfAo-0006Qb-QM for 8280@debbugs.gnu.org; Sun, 14 Aug 2011 14:12:36 -0400 Original-Received: from furball ([64.134.68.235]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p7EIAuBH003371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 14 Aug 2011 14:10:56 -0400 In-Reply-To: <87oc58h9nc.fsf@gmail.com> ("=?UTF-8?Q?Rafa=C3=ABl?= Fourquet"'s message of "Fri, 18 Mar 2011 13:53:59 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 14 Aug 2011 14:13:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50070 Archived-At: fourquet.d@gmail.com (Rafa=C3=ABl Fourquet) writes: > This bug is introduced by the fix of bug #7969, please tell me if I > should have re-opened this one. > > The infinite loop indicated in #7969 was fixed in file ibuf-ext.el > (commit 81911782 in git, Feb 2) by clearing all the filter groups > (ibuffer-filter-groups) in addition to the active filters > (ibuffer-filtering-qualifiers), in the function ibuffer-filter-disable. > I am not sure that this is what this function was intended to do. At > least it introduces an unwanted behavior: the function > ibuffer-filters-to-filter-group is supposed to transform active filters > into a filtering group, so it calls ibuffer-filter-disable once those > filters have been set as groups. But now, this last function clears > everything. Thanks for the analysis. I've committed the more conservative fix you suggested, i.e. adding an optional arg to ibuffer-filter-disable and using it in ibuffer-included-in-filter-p-1.