From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: bug / regression: C-x C-s is broken in org-edit-special Date: Sat, 18 Feb 2012 08:09:22 -0700 Message-ID: <87hayotarz.fsf@gmx.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:34823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RymJn-0004iB-ML for emacs-orgmode@gnu.org; Sat, 18 Feb 2012 10:35:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RymJm-0002Wo-JS for emacs-orgmode@gnu.org; Sat, 18 Feb 2012 10:35:23 -0500 Received: from mailout-us.gmx.com ([74.208.5.67]:56702) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1RymJm-0002Wc-Ba for emacs-orgmode@gnu.org; Sat, 18 Feb 2012 10:35:22 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Leo Alekseyev Cc: Emacs orgmode Thanks for posting this workaround. I've just pushed up a change which rebinds this key in org-src-mode. I don't know why the binding was ever removed in the first place. Best, Leo Alekseyev writes: > In case anyone is curious, C-x C-s functionality in org-edit-special > can be easily restored via > > (define-key org-src-mode-map "\C-x\C-s" 'org-edit-src-save) > > > On Thu, Feb 9, 2012 at 4:49 PM, Leo Alekseyev wrote: >> Previously, C-x C-s in an org-edit-special buffer (invoked via C-') >> would save the underlying org buffer (provided (setq >> org-src-window-setup (quote current-window)) was set; it was buggy >> with other settings, see >> http://thread.gmane.org/gmane.emacs.orgmode/50979 for discussion). >> Currently, C-x C-s prompts to save the temporary source edit buffer in >> a new file, which is almost certainly not what the user intends. =C2=A0I >> hope someone can look into this, C-x C-s shouldn't be broken in any >> context. >> >> This broke some time between commit >> fc93b6f34071703d5a154a51540f3f4e3f15b8a2 (Jan. 18) and this week, >> _possibly_ as a result of the change ensuring that buffer-file-name is >> nil in temporary org-src buffers. =C2=A0Buffer-file-name not being nil i= n a >> temp buffer is incorrect behavior, but in this context having C-x C-s >> not working is a much worse behavior, so perhaps that change ought to >> be reverted if it's the culprit. >> >> --Leo > --=20 Eric Schulte http://cs.unm.edu/~eschulte/