From: Nicolas Goaziou <n.goaziou@gmail.com>
To: "Mark E. Shoulson" <mark@kli.org>
Cc: org-mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: Entities
Date: Wed, 23 May 2012 23:53:39 +0200 [thread overview]
Message-ID: <87hav68syk.fsf@gmail.com> (raw)
In-Reply-To: <4FA9DBFA.8080405@kli.org> (Mark E. Shoulson's message of "Tue, 08 May 2012 22:52:42 -0400")
Hello,
"Mark E. Shoulson" <mark@kli.org> writes:
> There's a small bug in rendering the entities when org-pretty-entities
> is on (I get the feeling that org-pretty-entities is not a very
> commonly-used feature). The entities \sup1 \sup2 \sup3 and \there4 are
> not rendered properly. The regex detecting entities apparently doesn't
> catch numbers at the end, except for the special case of fractions. I've
> added the others to the special-casing and attach a patch for it; I
> hope I managed to include the changelog properly (is git format-patch -
> -attach the way to go?).
This looks good. You should add a title to your patch, like "Fix
detection of entities ending with a number" or "org-entities: Add some
entities".
Also, please capitalize the word after the colons.
> Also attached is another patch that might or might not be useful.
> Sometimes it can be a problem when you can't type, say, asterisks
> around a word when you NEED asterisks around the word, not a boldface
> word (I'd been getting around it by using Unicode characters that look
> like asterisks, like ∗). The way to do it right is to use the \ast
> entity, which expands to the right thing but doesn't affect
> formatting. There's also already a \tilde entity, to allow putting in
> tildes without accidentally setting something verbatim. I added
> entities for the remaining markup characters: \plus, \under, \equal,
> and \slash. \under might be particularly handy when avoiding
> subscripting (which raises the question of if there should be an
> \asciicirc (or something) entity for ^ also).
I think they are all useful. Though, asciicirc already exists as circ.
Could you modify slightly your changelogs before I apply the patches?
Thank you.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2012-05-23 21:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 2:52 Entities Mark E. Shoulson
2012-05-23 21:53 ` Nicolas Goaziou [this message]
2012-05-24 1:22 ` [PATCH] Fix for displaying entities ending in a number Mark E. Shoulson
2012-05-25 15:00 ` Nicolas Goaziou
2012-05-24 2:02 ` [PATCH] Add entities for /, +, _, = Mark E. Shoulson
2012-05-25 15:04 ` Nicolas Goaziou
2012-05-25 20:40 ` Mark E. Shoulson
2012-05-25 21:23 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hav68syk.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mark@kli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.