From: David Engster <deng@randomsample.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 11916@debbugs.gnu.org
Subject: bug#11916: 24.1.50; Making url-dav work
Date: Thu, 19 Jul 2012 17:28:29 +0200 [thread overview]
Message-ID: <87hat3kbxe.fsf@engster.org> (raw)
In-Reply-To: <jwvwr20w7ou.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 19 Jul 2012 03:15:29 -0400")
Stefan Monnier writes:
>> Just do an M-x occur on "'DAV:"; pretty much every test you see against
>> some symbol 'DAV:foo (about 30) has to be changed to test against
>> '("DAV" . "foo") instead. This also implies that every 'eq' has to be
>> changed to 'equal', 'assq' to 'assoc', 'plist-get' to 'lax-plist-get',
>> and so on. I started doing that and it just felt wrong; the code gets
>> larger, less readable and possibly slower without any real
>> benefit. However, I don't feel terribly strong about this, so if this
>> in-place XML change is considered too hack-ish, I can still finish that
>> rewrite.
>
> What would happen if url-dav.el didn't use namespaces (and just removed
> "DAV:" from all those symbols)?
You might get name clashes; for example, the code might parse a
'collection' although it is actually not a "DAV:collection" but a
"FOOBAR:collection". Granted, it's not very likely, and if this would be
used in a read-only fashion (like parsing atom feeds) I'd drop the
namespaces in a heartbeat. But since url-dav will usually be used to
manipulate actual files on remote servers, I'd rather not risk it.
>> I think namespace-aware parsing was added in 2004 or so, so changing it
>> now would surely break some code out there. Also, I could imagine that
>> under other circumstances you can profit from such a representation; but
>> url-dav simply wants to make sure that everything is in the 'DAV'
>> namespace.
>
> Of course, I was thinking of changing it in a backward compatible way,
> by letting the `parse-ns' argument specify which kind of result you
> want. The changes should be mostly limited to xml-maybe-do-ns.
I could live with that.
-David
next prev parent reply other threads:[~2012-07-19 15:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 21:00 bug#11916: 24.1.50; Making url-dav work David Engster
2012-07-18 12:25 ` Stefan Monnier
2012-07-18 17:45 ` David Engster
2012-07-19 7:15 ` Stefan Monnier
2012-07-19 15:28 ` David Engster [this message]
2012-07-19 22:12 ` Stefan Monnier
2012-07-21 12:11 ` David Engster
2012-07-22 10:11 ` Stefan Monnier
2012-07-25 21:04 ` David Engster
2012-07-26 0:04 ` Stefan Monnier
2012-07-26 16:01 ` David Engster
2012-07-26 23:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hat3kbxe.fsf@engster.org \
--to=deng@randomsample.de \
--cc=11916@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.