From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#14034: 24.3.50; M-/ runs diff-undo in Diff mode Date: Sat, 23 Mar 2013 21:55:35 +0400 Message-ID: <87hak2knia.fsf@yandex.ru> References: <514cd629.c552b40a.45ee.ffffb3e8@mx.google.com> <87d2uqu4b5.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364061492 30538 80.91.229.3 (23 Mar 2013 17:58:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Mar 2013 17:58:12 +0000 (UTC) Cc: 14034@debbugs.gnu.org To: Richard Copley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 23 18:58:38 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UJSi8-0002qR-Uq for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Mar 2013 18:58:33 +0100 Original-Received: from localhost ([::1]:51943 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJShl-000403-GN for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Mar 2013 13:58:09 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJShg-0003zy-UF for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 13:58:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJShb-00051G-QQ for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 13:58:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJShb-000511-Mr for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 13:57:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UJSja-0001Jg-47 for bug-gnu-emacs@gnu.org; Sat, 23 Mar 2013 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Mar 2013 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14034 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14034-submit@debbugs.gnu.org id=B14034.13640615704998 (code B ref 14034); Sat, 23 Mar 2013 18:00:02 +0000 Original-Received: (at 14034) by debbugs.gnu.org; 23 Mar 2013 17:59:30 +0000 Original-Received: from localhost ([127.0.0.1]:42480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UJSj3-0001IY-Ch for submit@debbugs.gnu.org; Sat, 23 Mar 2013 13:59:29 -0400 Original-Received: from mail-la0-f44.google.com ([209.85.215.44]:57759) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UJSj0-0001IQ-LH for 14034@debbugs.gnu.org; Sat, 23 Mar 2013 13:59:27 -0400 Original-Received: by mail-la0-f44.google.com with SMTP id eb20so9173697lab.3 for <14034@debbugs.gnu.org>; Sat, 23 Mar 2013 10:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:in-reply-to:date:references :user-agent:message-id:mime-version:content-type:x-antivirus :x-antivirus-status; bh=mdwsEMb5zKrDizlZdviIQoBnjeYymkRmUyo7ZlJcXzQ=; b=gO8aXKevH0Hjxs0TMRV5d/29QzTSd763F+Clwv0SK8mQAwtR5GrxpKLoJkuLN+X3M7 +HBmdq7ScDSAyvt+Qmi8/xynX1yh/V0WTZ125W7SVAxNlbf4ltJSnb5MqySGLI6v7SRZ siruQm4ASPX2koZQfbNYLGJeZzaAz/XFNDDQh1BoNpRdIzid6ran7ABLH6iW5HNqAnkT NGlef4aUASK/rMkNSL54On/5EjjLdtBPLc7xOZzQgV3PtBW6gVOTC/QasEu9WuZvZQe6 B94QO8Q6HVu1vsSt+GqdCNbfUP71q8xr00dwZQi4X+VMmQwDE/3NzLT5PA1SBhGKB65t mu5A== X-Received: by 10.112.49.201 with SMTP id w9mr3108200lbn.2.1364061442060; Sat, 23 Mar 2013 10:57:22 -0700 (PDT) Original-Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPS id t17sm2552619lam.9.2013.03.23.10.57.19 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 23 Mar 2013 10:57:20 -0700 (PDT) In-Reply-To: (Richard Copley's message of "Sat, 23 Mar 2013 16:48:51 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-Antivirus: avast! (VPS 130323-1, 23.03.2013), Outbound message X-Antivirus-Status: Clean X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72841 Archived-At: Version: 24.4 Richard Copley writes: >>> Looking at diff-mode code, it appears to me we should simply remove the >>> explicit "/" binding. `diff-mode-shared-map' already remaps undo to >>> diff-undo. > > Thanks, that would be great. Done, in trunk. >>> Where do these strange M- mappings come from? Specifying "x" in that >>> list binds "M-x" as well. That's crazy. >> >> That would be crazy, indeed. That's why there's no such `x' binding >> in there. > > I apologise, I obviously failed to express my point. What I meant is > that in my opinion, it is incorrect that if "x" were specified in that > list then "M-x" would be bound. I wasn't only referring to "M-x". I In general, you can add one entry to almost any keymap to screw things up (binding 'ignore to [remap save-buffers-kill-terminal], for example). > intended to include other keys, such as those I mentioned, which do > appear in the list: "M-o", "M-TAB", "M-{" and "M-}". If you disagree > or aren't interested, that's fine, and thanks anyway. Regarding curly braces, like the comment says, compilation-minor-mode does the same, so it's consistent, al least.