From: Dmitry Gutov <dgutov@yandex.ru>
To: Richard Copley <rcopley@gmail.com>
Cc: 14034@debbugs.gnu.org
Subject: bug#14034: 24.3.50; M-/ runs diff-undo in Diff mode
Date: Sat, 23 Mar 2013 21:55:35 +0400 [thread overview]
Message-ID: <87hak2knia.fsf@yandex.ru> (raw)
In-Reply-To: <CAPM58oh-m99F3qqg5eHm5=KnXLL=0Qe12yFdcvT9ahDYatnmrg@mail.gmail.com> (Richard Copley's message of "Sat, 23 Mar 2013 16:48:51 +0000")
Version: 24.4
Richard Copley <rcopley@gmail.com> writes:
>>> Looking at diff-mode code, it appears to me we should simply remove the
>>> explicit "/" binding. `diff-mode-shared-map' already remaps undo to
>>> diff-undo.
>
> Thanks, that would be great.
Done, in trunk.
>>> Where do these strange M- mappings come from? Specifying "x" in that
>>> list binds "M-x" as well. That's crazy.
>>
>> That would be crazy, indeed. That's why there's no such `x' binding
>> in there.
>
> I apologise, I obviously failed to express my point. What I meant is
> that in my opinion, it is incorrect that if "x" were specified in that
> list then "M-x" would be bound. I wasn't only referring to "M-x". I
In general, you can add one entry to almost any keymap to screw things
up (binding 'ignore to [remap save-buffers-kill-terminal], for example).
> intended to include other keys, such as those I mentioned, which do
> appear in the list: "M-o", "M-TAB", "M-{" and "M-}". If you disagree
> or aren't interested, that's fine, and thanks anyway.
Regarding curly braces, like the comment says, compilation-minor-mode
does the same, so it's consistent, al least.
prev parent reply other threads:[~2013-03-23 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 22:07 bug#14034: 24.3.50; M-/ runs diff-undo in Diff mode rcopley
2013-03-23 4:29 ` Dmitry Gutov
2013-03-23 10:27 ` Richard Copley
2013-03-23 16:14 ` Stefan Monnier
2013-03-23 16:48 ` Richard Copley
2013-03-23 17:55 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hak2knia.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=14034@debbugs.gnu.org \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.