From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Aidan Gauland Newsgroups: gmane.emacs.diffs,gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r112148: Added eshell-tramp module Date: Fri, 29 Mar 2013 09:03:11 +1300 Message-ID: <87hajvnvgg.fsf@dimension8.tehua.net> References: <87wqst2vw3.fsf@no8wireless.co.nz> <87hajw6iog.fsf@no8wireless.co.nz> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1364501015 16891 80.91.229.3 (28 Mar 2013 20:03:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Mar 2013 20:03:35 +0000 (UTC) Cc: emacs-diffs@gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Thu Mar 28 21:04:02 2013 Return-path: Envelope-to: gnu-emacs-diffs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ULJ3E-00086S-WA for gnu-emacs-diffs@m.gmane.org; Thu, 28 Mar 2013 21:03:57 +0100 Original-Received: from localhost ([::1]:39801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULJ2q-0002zw-R4 for gnu-emacs-diffs@m.gmane.org; Thu, 28 Mar 2013 16:03:32 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULJ2j-0002tk-KI for emacs-diffs@gnu.org; Thu, 28 Mar 2013 16:03:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULJ2g-0001NF-7w for emacs-diffs@gnu.org; Thu, 28 Mar 2013 16:03:25 -0400 Original-Received: from jersey.rurallink.co.nz ([114.134.15.197]:46184 helo=smtp.rurallink.co.nz) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULJ2Z-0001Lf-Ri; Thu, 28 Mar 2013 16:03:16 -0400 Original-Received: from 114-134-7-65.rurallink.co.nz ([114.134.7.65] helo=dimension8.tehua.net) by smtp.rurallink.co.nz with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1ULJ2X-0004aD-Hw; Fri, 29 Mar 2013 09:03:14 +1300 In-Reply-To: (Stefan Monnier's message of "Thu, 28 Mar 2013 09:16:52 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-Rurallink-Authenticated-User: aidalgol@no8wireless.co.nz X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 114.134.15.197 X-BeenThere: emacs-diffs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Mailing list for Emacs changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Original-Sender: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.diffs:120073 gmane.emacs.devel:158379 Archived-At: Stefan Monnier writes: >>> This said, IIUC just loading eshell-tramp.el will also enable it (tho >>> not "completely"). That's a problem (and yes, this is not a new >>> problem, it's just a problem in most/all eshell modules). >> Yes, if the feature `em-tramp' is loaded but the module is not enabled, >> then it is just taking up memory and doing nothing. > > Just taking up memory is not a problem. But IIUC since it defines > eshell/su, it will have an impact on eshell buffers, even if > eshell-tramp-initialize is not called, right? Oh, no, that won't be a problem, because eshell-tramp-initialize has to be called (for each buffer) to register the functions. em-tramp.el line 51: (make-local-variable 'eshell-complex-commands) (setq eshell-complex-commands (append '("su" "sudo") eshell-complex-commands)) So if the module is enabled (and loaded, of course), and you disable it and then create a new eshell buffer, running the commands su and sudo will invoke the external commands, not the internal eshell/su and eshell/sudo. --Aidan (Sorry for the duplicate; I keep hitting R instead of F in Gnus.)