From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115470: eww: exit and close actions Date: Thu, 12 Dec 2013 14:17:08 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87haadq3pn.fsf@flea.lifelogs.com> References: Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1386875778 25958 80.91.229.3 (12 Dec 2013 19:16:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 12 Dec 2013 19:16:18 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 12 20:16:23 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VrBkE-0000pE-Ih for ged-emacs-devel@m.gmane.org; Thu, 12 Dec 2013 20:16:22 +0100 Original-Received: from localhost ([::1]:38293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrBkE-0006Zp-4P for ged-emacs-devel@m.gmane.org; Thu, 12 Dec 2013 14:16:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrBk6-0006Zb-2x for emacs-devel@gnu.org; Thu, 12 Dec 2013 14:16:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrBk0-0000mc-HI for emacs-devel@gnu.org; Thu, 12 Dec 2013 14:16:14 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:53307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrBk0-0000m4-20 for emacs-devel@gnu.org; Thu, 12 Dec 2013 14:16:08 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1VrBjy-0000an-31 for emacs-devel@gnu.org; Thu, 12 Dec 2013 20:16:06 +0100 Original-Received: from c-98-229-61-72.hsd1.ma.comcast.net ([98.229.61.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 12 Dec 2013 20:16:06 +0100 Original-Received: from tzz by c-98-229-61-72.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 12 Dec 2013 20:16:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 37 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-98-229-61-72.hsd1.ma.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:6d9pFC9xH8MuOj5vQ4OH1mCzQqk= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:166350 Archived-At: On Thu, 12 Dec 2013 13:52:48 -0500 Stefan Monnier wrote: >> +(defun eww-exit () >> + "Exit the Emacs Web Wowser." >> + (interactive) >> + (setq eww-history nil) >> + (kill-buffer (current-buffer))) >> + >> +(defun eww-close () >> + "Close the Emacs Web Wowser browser, leaving history intact." >> + (interactive) >> + (quit-window)) SM> I think this is a step backward. The names `eww-close' and `eww-exit' SM> don't help the user understand what those commands do. To me they sound SM> like different names for the same thing. I think `close' and `exit' in the context of a web browser are very clear concepts. Do you think any users are unfamiliar with web browsers? Or do you want to give Emacs-specific names to these concepts? I would rather avoid this Emacsification[1], personally, and have done my best to help eww users, but eww is not my project so I'll leave it to Lars and you to settle it. SM> I'd rather use commands `kill-this-buffer' and `quit-window' which are SM> much more clear and which the user might already know. SM> I'm not sure how (setq eww-history nil) fits in there, because I don't SM> know why it's there, so I can't comment on how best to go about it in SM> this respect. It ensures that the browsing history is erased, which `kill-buffer' may not do. This was in Lars' original code as `eww-quit' so I kept it. Ted