From: Ted Zlatanov <tzz@lifelogs.com>
To: "Jarosław Rzeszótko" <sztywny@gmail.com>
Cc: 16220@debbugs.gnu.org
Subject: bug#16220: url-http.el: Not conforming to HTTP spec
Date: Mon, 23 Dec 2013 08:08:42 -0500 [thread overview]
Message-ID: <87ha9zaf51.fsf@flea.lifelogs.com> (raw)
In-Reply-To: <CAHnYAZbcgts3siT6ELhAfz0g2q+JBrZWE-JXtQdxFC4qWg-eGQ@mail.gmail.com> ("Jarosław Rzeszótko"'s message of "Mon, 23 Dec 2013 07:51:57 +0100")
On Mon, 23 Dec 2013 07:51:57 +0100 Jarosław Rzeszótko <sztywny@gmail.com> wrote:
JR> I hope this is enough of a proof that the extra newline is a bug.
I was already convinced :)
JR> 2013/12/22 Ted Zlatanov <tzz@lifelogs.com>:
>> On Sun, 22 Dec 2013 22:55:07 +0100 Jarosław Rzeszótko <sztywny@gmail.com> wrote:
>>
JR> To turn this into a concrete proposal: I suggest this part in url-http.el
JR> (starting line 356 in trunk):
>>
JR> ;; End request
JR> "\r\n"
JR> ;; Any data
JR> url-http-data
JR> ;; If `url-http-data' is nil, avoid two CRLFs (Bug#8931).
JR> (if url-http-data "\r\n")))
>>
JR> Should read simply:
>>
JR> ;; End request
JR> "\r\n"
JR> ;; Any data
JR> url-http-data))
>> ...
I am OK with this fix, if anyone else wants to look it over and commit.
JR> Futhermore url-http-attempt-keepalives should be nil as default, or better
JR> yet should be completely removed, as true keepalive connections are anyway
JR> not currently supported on the Emacs side, are they?
Not AFAIK.
Ted
next prev parent reply other threads:[~2013-12-23 13:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 20:52 bug#16220: url-http.el: Not conforming to HTTP spec Jarosław Rzeszótko
2013-12-22 21:55 ` Jarosław Rzeszótko
2013-12-22 22:33 ` Ted Zlatanov
2013-12-23 6:51 ` Jarosław Rzeszótko
2013-12-23 13:08 ` Ted Zlatanov [this message]
2013-12-24 7:50 ` Lars Ingebrigtsen
2013-12-24 8:28 ` Jarosław Rzeszótko
2013-12-24 14:43 ` Stefan Monnier
2013-12-24 16:31 ` Jarosław Rzeszótko
2014-01-02 2:21 ` Stefan Monnier
2014-01-03 18:06 ` Jarosław Rzeszótko
2014-01-05 9:57 ` Lars Magne Ingebrigtsen
2014-01-05 13:25 ` Jarosław Rzeszótko
2014-01-06 15:06 ` Stefan Monnier
2014-01-07 19:30 ` Jarosław Rzeszótko
2014-01-08 18:29 ` Stefan Monnier
2014-01-18 22:35 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha9zaf51.fsf@flea.lifelogs.com \
--to=tzz@lifelogs.com \
--cc=16220@debbugs.gnu.org \
--cc=sztywny@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.