From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#16198: 24.3.50; [PATCH 1/2] eww: Does not support file upload. Date: Tue, 24 Dec 2013 08:32:56 +0100 Message-ID: <87ha9yzot3.fsf@building.gnus.org> References: <87fvpnzx8e.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387870820 18464 80.91.229.3 (24 Dec 2013 07:40:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Dec 2013 07:40:20 +0000 (UTC) Cc: 16198@debbugs.gnu.org To: Kenjiro NAKAYAMA Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 24 08:40:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VvMbD-0006Nq-I8 for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2013 08:40:19 +0100 Original-Received: from localhost ([::1]:36937 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMbD-0001BN-7q for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Dec 2013 02:40:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMb4-0001A7-99 for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:40:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvMay-0001Im-4J for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:40:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvMay-0001II-1C for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:40:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VvMaw-0000a1-Fl for bug-gnu-emacs@gnu.org; Tue, 24 Dec 2013 02:40:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2013 07:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16198-submit@debbugs.gnu.org id=B16198.13878707502099 (code B ref 16198); Tue, 24 Dec 2013 07:40:02 +0000 Original-Received: (at 16198) by debbugs.gnu.org; 24 Dec 2013 07:39:10 +0000 Original-Received: from localhost ([127.0.0.1]:37549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvMa5-0000Xj-Ae for submit@debbugs.gnu.org; Tue, 24 Dec 2013 02:39:09 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:35491) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvMa2-0000XT-AQ for 16198@debbugs.gnu.org; Tue, 24 Dec 2013 02:39:07 -0500 Original-Received: from 77.18.245.69.tmi.telenormobil.no ([77.18.245.69] helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VvMZn-0007Tu-It; Tue, 24 Dec 2013 08:38:51 +0100 In-Reply-To: <87fvpnzx8e.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Fri, 20 Dec 2013 18:29:37 +0900") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1VvMZn-0007Tu-It MailScanner-NULL-Check: 1388475532.25518@NSNWDS+MvECPsuovQx0NEA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82495 Archived-At: Kenjiro NAKAYAMA writes: > This report includes a patch to eww file upload. Please, review and > install it to the official tree if appreciated. It sounds like useful functionality, but Emacs went into feature freeze yesterday, so it'll have to wait until Emacs thaws again. Comment about the code: > + (concat > + "Content-Disposition: form-data;name=" (car data) "\r\n\r\n" > + (concat (mm-url-form-encode-xwfu (cdr data)) > + ))) > + )) This is not the Emacs parenthesis style. All the closing parentheses should be on the same line. And there's a superfluous `concat' there... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/