From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Changes in update-game-score.c Date: Wed, 22 Jan 2014 20:50:19 +0100 Organization: Organization?!? Message-ID: <87ha8vn6dg.fsf@fencepost.gnu.org> References: <8361pbg5vy.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1390420245 24666 80.91.229.3 (22 Jan 2014 19:50:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jan 2014 19:50:45 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 22 20:50:52 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W63p4-0004Yk-IK for ged-emacs-devel@m.gmane.org; Wed, 22 Jan 2014 20:50:50 +0100 Original-Received: from localhost ([::1]:37287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W63p4-0005aJ-6j for ged-emacs-devel@m.gmane.org; Wed, 22 Jan 2014 14:50:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48987) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W63ou-0005RG-QU for emacs-devel@gnu.org; Wed, 22 Jan 2014 14:50:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W63oo-0006fK-HY for emacs-devel@gnu.org; Wed, 22 Jan 2014 14:50:40 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:36073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W63on-0006fC-VT for emacs-devel@gnu.org; Wed, 22 Jan 2014 14:50:34 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1W63oj-0004Pz-KA for emacs-devel@gnu.org; Wed, 22 Jan 2014 20:50:29 +0100 Original-Received: from x2f50d2c.dyn.telefonica.de ([2.245.13.44]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 Jan 2014 20:50:29 +0100 Original-Received: from dak by x2f50d2c.dyn.telefonica.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 22 Jan 2014 20:50:29 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 23 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: x2f50d2c.dyn.telefonica.de X-Face: 2FEFf>]>q>2iw=B6, xrUubRI>pR&Ml9=ao@P@i)L:\urd*t9M~y1^:+Y]'C0~{mAl`oQuAl \!3KEIp?*w`|bL5qr,H)LFO6Q=qx~iH4DN; i"; /yuIsqbLLCh/!U#X[S~(5eZ41to5f%E@'ELIi$t^ Vc\LWP@J5p^rst0+('>Er0=^1{]M9!p?&:\z]|;&=NP3AhB!B_bi^]Pfkw User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:opAOv7bteCIK7pTiNASPrz8obGQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:168919 Archived-At: Eli Zaretskii writes: > Can we please stop futzing with this silly program, while in feature > freeze? Why do we suddenly care about it so much? Those changes do > nothing useful, and risk breaking builds, e.g.: > > ./update-game-score.c: In function `write_scores': > ./update-game-score.c:446: warning: implicit declaration of function `fchmod' > gcc -std=gnu99 -mtune=pentium4 -I. -I../src -I../lib -I. -I./../src > -I./../lib -mtune=pentium4 -DUSE_CRT_DLL=1 -I > /d/gnu/bzr/emacs/trunk/nt/inc -O0 -gdwarf-2 -g3 -o test-distrib.exe > ./test-distrib.c > d:/usr/tmp/cckhdaaa.o(.text+0xe24): In function `write_scores': > d:\gnu\bzr\emacs\trunk\lib-src/./update-game-score.c:446: undefined > reference to `fchmod' > collect2: ld returned 1 exit status You fixed the breakage for Windows NT, but fchmod is not generally available on a _lot_ of platforms. Without a proper autoconf test, the whole change should be reverted. -- David Kastrup