From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: trunk r116499: Improve dbus error handling; detect bus failure Date: Mon, 24 Feb 2014 09:18:35 +0100 Message-ID: <87ha7ogbz8.fsf@gmx.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1393229932 6759 80.91.229.3 (24 Feb 2014 08:18:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Feb 2014 08:18:52 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 24 09:19:00 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WHqkd-0004zw-HA for ged-emacs-devel@m.gmane.org; Mon, 24 Feb 2014 09:18:59 +0100 Original-Received: from localhost ([::1]:56246 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHqkd-0004Xi-3w for ged-emacs-devel@m.gmane.org; Mon, 24 Feb 2014 03:18:59 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHqkT-0004Wi-BJ for emacs-devel@gnu.org; Mon, 24 Feb 2014 03:18:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHqkM-00083z-0l for emacs-devel@gnu.org; Mon, 24 Feb 2014 03:18:49 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:60477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHqkL-00083h-Nv for emacs-devel@gnu.org; Mon, 24 Feb 2014 03:18:41 -0500 Original-Received: from detlef.gmx.de ([87.146.47.186]) by mail.gmx.com (mrgmx002) with ESMTPS (Nemesis) id 0LlESk-1Wrk3k1yRK-00b2KX for ; Mon, 24 Feb 2014 09:18:39 +0100 In-Reply-To: (Daniel Colascione's message of "Fri, 21 Feb 2014 04:32:57 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:cV/CMdk6rD9TwXjXRYfze0QGsnhPnOsSgGJjLe7KxHJHCDGwWTm aVE6Q5BmVMtZNJ9HA1gwCPBhAoGFP6cde1kKmB9MKjMPYw4mRz+nmqFCSW0xun5UAFcI+7X /Wvsv88LuMOkVGxhX0nU3mzCWgzPvOr/adktc9jDwhOBTR2ZLY+C+04p616yrOn+bM9nn1F JlERzrfeGaLEo42urjffA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169826 Archived-At: Daniel Colascione writes: > + (dbus-handle-bus-disconnect): New function. React to bus > + disconnection signal by synthesizing dbus error for each > + pending synchronous or asynchronous call. This is a new functionality. Why do you want to add it during feature freeze? And what is the reasoning behind? When a D-Bus bus disconnects, there might be more serious problems but pending method calls. Is it about performance, and abortion of such pending calls? When does it happen, that a bus disconnect for you? > + (dbus-notice-synchronous-call-errors): New function. > + (dbus-handle-event): Raise errors directly only when `dbus-debug' > + is true, not all the time. Why that? You cannot assume that `dbus-event-error-functions' is non-nil (and contains `dbus-notice-synchronous-call-errors'). I still don't see what you are trying to resolve. Lisp errors are shown when happening in handlers, what else do you want to achieve? As usual a typical use case would help. And *if* you are applying such changes, I would expect respective doc changes, for example explainig the (changed) structure of the values in `dbus-return-values-table', or mentioning `dbus-notice-synchronous-call-errors' and its intended use in dbus.texi. In short, I'm not against such changes if the intention is understood. But I believe it is a bad timing to apply them during feature freeze, and w/o discussing them in emacs-devel. Best regards, Michael.