From: Michael Albinus <michael.albinus@gmx.de>
To: Daniel Colascione <dancol@dancol.org>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r116499: Improve dbus error handling; detect bus failure
Date: Mon, 24 Feb 2014 09:18:35 +0100 [thread overview]
Message-ID: <87ha7ogbz8.fsf@gmx.de> (raw)
In-Reply-To: <E1WGhnF-0006bq-Ma@vcs.savannah.gnu.org> (Daniel Colascione's message of "Fri, 21 Feb 2014 04:32:57 +0000")
Daniel Colascione <dan.colascione@gmail.com> writes:
> + (dbus-handle-bus-disconnect): New function. React to bus
> + disconnection signal by synthesizing dbus error for each
> + pending synchronous or asynchronous call.
This is a new functionality. Why do you want to add it during feature
freeze? And what is the reasoning behind? When a D-Bus bus disconnects,
there might be more serious problems but pending method calls.
Is it about performance, and abortion of such pending calls? When does
it happen, that a bus disconnect for you?
> + (dbus-notice-synchronous-call-errors): New function.
> + (dbus-handle-event): Raise errors directly only when `dbus-debug'
> + is true, not all the time.
Why that? You cannot assume that `dbus-event-error-functions' is non-nil
(and contains `dbus-notice-synchronous-call-errors').
I still don't see what you are trying to resolve. Lisp errors are shown
when happening in handlers, what else do you want to achieve? As usual a
typical use case would help.
And *if* you are applying such changes, I would expect respective doc
changes, for example explainig the (changed) structure of the values in
`dbus-return-values-table', or mentioning
`dbus-notice-synchronous-call-errors' and its intended use in dbus.texi.
In short, I'm not against such changes if the intention is
understood. But I believe it is a bad timing to apply them during
feature freeze, and w/o discussing them in emacs-devel.
Best regards, Michael.
next parent reply other threads:[~2014-02-24 8:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WGhnF-0006bq-Ma@vcs.savannah.gnu.org>
2014-02-24 8:18 ` Michael Albinus [this message]
2014-02-24 8:24 ` trunk r116499: Improve dbus error handling; detect bus failure Daniel Colascione
2014-02-24 8:54 ` Michael Albinus
2014-02-24 11:45 ` Peter Münster
2014-02-24 12:50 ` Daniel Colascione
2014-02-24 12:59 ` Daniel Colascione
2014-02-24 13:09 ` Michael Albinus
2014-02-24 13:14 ` Michael Albinus
2014-02-24 13:48 ` Daniel Colascione
2014-02-24 14:25 ` Michael Albinus
2014-02-24 18:52 ` Peter Münster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha7ogbz8.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.