From: Eric Schulte <schulte.eric@gmail.com>
To: Pontus Michael <m.pontus@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Noweb expansion doesn't duplicate prefix across lines
Date: Wed, 02 Apr 2014 17:07:07 -0600 [thread overview]
Message-ID: <87ha6ao5xj.fsf@gmail.com> (raw)
In-Reply-To: CAPpfmH+n=K5YL+vSGkj6k9xLco8PmOJzMXi=CDBekNBa0ZRBxQ@mail.gmail.com
This simply seems to trade one use case (noweb expansion behind a
prefix), with another (multiple noweb expansions on the same line).
Is there a way to support both use cases?
Pontus Michael <m.pontus@gmail.com> writes:
> * lisp/ob-core.el (org-babel-expand-noweb-references): Change the the
> behavior of noweb expansion by replacing the prefix duplication with
> whitespace. Fix handling of multiple noweb references on the same
> line by using temporary buffer to replace noweb references in place
> instead of collecting the intervals between references and their
> expansion text into a variable.
>
> * doc/org.texi: Reflect the change by removing the section under
> subheading "Noweb prefix lines".
>
> Tests pass and don't require actualization.
> ---
> doc/org.texi | 24 ------------------------
> lisp/ob-core.el | 26 +++++++-------------------
> 2 files changed, 7 insertions(+), 43 deletions(-)
>
--
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D
next prev parent reply other threads:[~2014-04-03 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 2:19 [PATCH] Noweb expansion doesn't duplicate prefix across lines Pontus Michael
2014-04-02 23:07 ` Eric Schulte [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-03 17:37 Pontus Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha6ao5xj.fsf@gmail.com \
--to=schulte.eric@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=m.pontus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.