From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#17295: 24.3; Add TRAMP fixes for history clobbering to pretest Date: Mon, 28 Apr 2014 12:07:53 +0200 Message-ID: <87ha5du5qe.fsf@gmx.de> References: <87tx9q1x35.fsf@gmail.com> <8761m078ty.fsf@gmx.de> <20140428074632.GA799@odonien.bg.bib.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1398679771 6620 80.91.229.3 (28 Apr 2014 10:09:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Apr 2014 10:09:31 +0000 (UTC) Cc: 17295@debbugs.gnu.org To: Vasilij Schneidermann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 28 12:09:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WeiUy-0001Gb-EG for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Apr 2014 12:09:20 +0200 Original-Received: from localhost ([::1]:42746 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeiUx-0004Wh-Ff for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Apr 2014 06:09:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeiUp-0004WW-3U for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 06:09:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WeiUh-0000r5-Ct for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 06:09:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WeiUh-0000qv-9U for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 06:09:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WeiUg-0000pg-JK for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2014 06:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Apr 2014 10:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 17295-submit@debbugs.gnu.org id=B17295.13986796853114 (code B ref 17295); Mon, 28 Apr 2014 10:09:02 +0000 Original-Received: (at 17295) by debbugs.gnu.org; 28 Apr 2014 10:08:05 +0000 Original-Received: from localhost ([127.0.0.1]:43609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WeiTk-0000o9-Cq for submit@debbugs.gnu.org; Mon, 28 Apr 2014 06:08:04 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:58671) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WeiTh-0000nZ-VB for 17295@debbugs.gnu.org; Mon, 28 Apr 2014 06:08:02 -0400 Original-Received: from detlef.gmx.de ([87.146.61.136]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LwGDy-1Wx3IL09K2-0181rr; Mon, 28 Apr 2014 12:07:55 +0200 In-Reply-To: <20140428074632.GA799@odonien.bg.bib.de> (Vasilij Schneidermann's message of "Mon, 28 Apr 2014 09:46:32 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Provags-ID: V03:K0:2W89JmuNmm9Xa0X/e3cVJh58BbcyvmCL9JRsApUwqsNvdTI7yAd jHNNIOhvlplm0PjgX3Rvz7YCjk7tGl8R6Fn0wqSHdO5TzAHY+93f/hJ59BURFbFoztRUy2l Xr84RwSXPOC4TIfd+cjC0q097ChXsa9UujYBCKMhOzYkcJMgynIoW7ZCPy27M+B+sSuV/AB M0vafmaOoBgXVSNX6m9Dg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88349 Archived-At: Vasilij Schneidermann writes: > Hi Michael, Hi Vasilij, [pls keep 17295@debbugs.gnu.org in Cc, for the archives] > I've applied the patch successfully and did a comparision test between > both Emacs 24.3.1 and 24.3.90. In that test I first open a file from a > remote host via `C-x C-f /ssh:user@host:/path/to/file`, then open a > shell, do `ssh user@host` and hit `C-p` to check whether the history > file has been clobbered. > > With Emacs 24.3.1 the test output is: > > [user@host ~]$ exec env ENV='' PROMPT_COMMAND='' PS1=\#\$\ PS2='' PS3='' /bin/sh > > With the patched Emacs 24.3.90 the test output is: > > [user@host ~]$ exec env ENV='' HISTFILE=/dev/null PROMPT_COMMAND='' PS1=\#\$\ PS2='' PS3='' /bin/sh > > So, the difference seems to be an extra environment variable set. > Clobbering on the remote side is not prevented. Perhaps it the changes > prevent it on the local side? I'm not sure as I've only briefly looked > at TRAMP internals and didn't understand much. In the past, *all* Tramp commands were visible in your remote history file. With my patch, only the very first command is still visible, the one you have quoted. Tramp cannot avoid this behaviour, because it has no mean to set the remote environment prior running the very first command. You could do this yourself by creating a local ~/.ssh/environment file, containing HISTFILE=/dev/null See the ssh(1) manpage for details. The local history shall be clean, because Tramp sets $HISTFILE locally prior to calling anything. > Best regards > Vasilij Best regards, Michael.