From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: Emacs-diffstrunk r117208: * lisp/files.el (locate-dominating-file): Expand file argument. Date: Sun, 01 Jun 2014 09:50:01 +0200 Message-ID: <87ha45vzkm.fsf@gmx.de> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1401609032 4307 80.91.229.3 (1 Jun 2014 07:50:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Jun 2014 07:50:32 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 01 09:50:25 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wr0X9-00086y-HV for ged-emacs-devel@m.gmane.org; Sun, 01 Jun 2014 09:50:23 +0200 Original-Received: from localhost ([::1]:34167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wr0X8-0006nk-NL for ged-emacs-devel@m.gmane.org; Sun, 01 Jun 2014 03:50:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wr0X0-0006nd-VL for emacs-devel@gnu.org; Sun, 01 Jun 2014 03:50:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wr0Wv-0001Q0-26 for emacs-devel@gnu.org; Sun, 01 Jun 2014 03:50:14 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:51657) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wr0Wu-0001P1-Pt; Sun, 01 Jun 2014 03:50:08 -0400 Original-Received: from detlef.gmx.de ([87.146.60.64]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M0h9K-1WXXy116eE-00usf5; Sun, 01 Jun 2014 09:50:03 +0200 In-Reply-To: (Glenn Morris's message of "Sat, 31 May 2014 15:27:13 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-Provags-ID: V03:K0:i2RLvh5lcFKm1h4pwdG01BLVUPRepiZRMZTb7O9iiu9uT9x17Q/ /7raAI/l33+azsQU7EYJIx5j/Vbg/U9Yqy/GTGozU95vcD0jwLRXASmknDyF8ZOfIzG9aZC 3evdGYXSpzlx+rkDEOjdLZFYLnTgTC59wD0fxG2TE7vVMIH5/d3kg0b16Srnl8g7h1GAkzb PJBWS1PFtUCSlbK167ykA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.15.19 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172237 Archived-At: Glenn Morris writes: > Hi Michael, Hi Glenn, > Unless it is a hydra glitch (always possible), my trunk r117208 seems to > cause tramp-test29-vc-registered to fail on hydra. Any ideas? I've seen this already (but wasn't aware which change caused the error). Tramp does some optimization in its vc-registered implementation, maybe they are not compatible with your recent change. I'll check. In this respect, the test does what it is intended to do - flag problems :-) > BTW, I think that test should set the BZR_HOME environment variable, > like test/automated/vc-bzr.el does. This will be good not just for > hydra, but to stop tests writing to ~/.bzr.log in general. Yes. However, it's not guaranteed that tramp-test29-vc-registered chooses bzr. It could also take git or hg, whatever it finds on the test machine. A bzr only change will be good for hydra, but maybe we need some more general consideration here. OTOH, it's not guaranteed that all people have set BZR_HOME. Couldn't this setting hide problems, which would be detected otherwise in the tests? Best regards, Michael.