From: Michael Albinus <michael.albinus@gmx.de>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs-diffstrunk r117208: * lisp/files.el (locate-dominating-file): Expand file argument.
Date: Sun, 01 Jun 2014 09:50:01 +0200 [thread overview]
Message-ID: <87ha45vzkm.fsf@gmx.de> (raw)
In-Reply-To: <jfy4xhycj2.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sat, 31 May 2014 15:27:13 -0400")
Glenn Morris <rgm@gnu.org> writes:
> Hi Michael,
Hi Glenn,
> Unless it is a hydra glitch (always possible), my trunk r117208 seems to
> cause tramp-test29-vc-registered to fail on hydra. Any ideas?
I've seen this already (but wasn't aware which change caused the error).
Tramp does some optimization in its vc-registered implementation, maybe
they are not compatible with your recent change. I'll check. In this
respect, the test does what it is intended to do - flag problems :-)
> BTW, I think that test should set the BZR_HOME environment variable,
> like test/automated/vc-bzr.el does. This will be good not just for
> hydra, but to stop tests writing to ~/.bzr.log in general.
Yes. However, it's not guaranteed that tramp-test29-vc-registered
chooses bzr. It could also take git or hg, whatever it finds on the test
machine. A bzr only change will be good for hydra, but maybe we need
some more general consideration here.
OTOH, it's not guaranteed that all people have set BZR_HOME. Couldn't
this setting hide problems, which would be detected otherwise in the tests?
Best regards, Michael.
next prev parent reply other threads:[~2014-06-01 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1WqZ19-0003OV-AT@vcs.savannah.gnu.org>
2014-05-31 19:27 ` Emacs-diffstrunk r117208: * lisp/files.el (locate-dominating-file): Expand file argument Glenn Morris
2014-06-01 7:50 ` Michael Albinus [this message]
2014-06-01 17:23 ` Glenn Morris
2014-06-01 17:59 ` Michael Albinus
2014-06-01 22:22 ` Glenn Morris
2014-06-02 18:42 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ha45vzkm.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.