Request to patch the =org-html-fontify-code= function in =ox-html.el=

Request to patch the =org-html-fontify-code= function in =ox-html.el=

[Kaushal]

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

Hi,

I have been using org for technical documentation and that involves
inserted code snippets.  The org to pdf export works great but I faced
issues when exporting to html.

After some digging around, I figured that having fci-mode enabled on a
LANG-mode-hook caused insertion of some strange unicode characters in the
html converted version.

Full details are in my reddit post here:
http://www.reddit.com/r/emacs/comments/2b5x5g/funny_characters_appended_at_new_line_to_source/

To fix this problem by adding the following code after the line (funcall
lang-mode) in the org-html-fontify-code defun in ox-html.el.

(when (require 'fill-column-indicator nil 'noerror)
    (fci-mode -1))

Can this fix be integrated into ox-html.el?


Thanks.


--
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 3335 bytes --]

Re: Request to patch the =org-html-fontify-code= function in =ox-html.el=

[Nick Dokos]

Kaushal <kaushal.modi@gmail.com> writes:

> Full details are in my reddit post here:
> http://www.reddit.com/r/emacs/comments/2b5x5g/funny_characters_appended_at_new_line_to_source/
>


> To fix this problem by adding the following code after the
> line (funcall lang-mode) in the org-html-fontify-code defun
> in ox-html.el.
>
> (when (require 'fill-column-indicator nil 'noerror)
>     (fci-mode -1))
>
> Can this fix be integrated into ox-html.el? 
>

Not really: the above would cause an error if fci-mode is
undefined. You'll have to add a bit more checking before
calling it - check out the doc for fboundp:

        C-h f fboundp RET

-- 
Nick

Re: Request to patch the =org-html-fontify-code= function in =ox-html.el=

[Bastien]

Nick Dokos <ndokos@gmail.com> writes:

>> To fix this problem by adding the following code after the
>> line (funcall lang-mode) in the org-html-fontify-code defun
>> in ox-html.el.
>>
>> (when (require 'fill-column-indicator nil 'noerror)
>>     (fci-mode -1))
>>
>> Can this fix be integrated into ox-html.el? 
>>
>
> Not really: the above would cause an error if fci-mode is
> undefined. You'll have to add a bit more checking before
> calling it - check out the doc for fboundp:
>
>         C-h f fboundp RET

I added such a check in `org-html-fontify-code', thanks,

-- 
 Bastien