From: David Engster <deng@randomsample.de>
To: Eric Ludlam <eric@siege-engine.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Shrinking EIEIO objects
Date: Fri, 02 Jan 2015 12:22:17 +0100 [thread overview]
Message-ID: <87h9w9whp2.fsf@engster.org> (raw)
In-Reply-To: <54A6053B.5060001@siege-engine.com> (Eric Ludlam's message of "Thu, 01 Jan 2015 21:40:59 -0500")
Eric Ludlam writes:
> On 12/30/2014 12:59 PM, Stefan Monnier wrote:
>> Hi Eric,
>>
>> I'd like to install something like the patch below into Emacs's master.
>> What it does (along with various other side changes) is shorten the
>> object header from 3 fields (the constant `object', the class name, and
>> an object "name" field) to just one (an interned symbol with an "eieio-"
>> prefix, referring to the class object).
>
> This seems like a fine idea. A side effect is that the 'name' slot is
> gone. There have received a questions about why there is a 'name' for
> objects, and really the main thing was debugging. When you have piles
> of objects around, naming them makes it much easier to see what is
> going on. EIEIO objects have a short hand using a #<class name>
> format, and when the various prin1 tools are enabled for edebug, that
> short hand is used in place of the vector. This is critical when
> debugging semantic databases where the vectors contain thousands of
> symbols.
>
> Your proposed solution will enable the current source forge hosted
> version of CEDET to keep going, just with warning messages, which
> seems fine.
>
> I can convert the sourceforge version CEDET to use make-instance
> instead, which should be compatible before and after your change.
I'm a bit confused. Why would we need to change how we construct our
objects? Most of these changes seem to be purely internal. The only API
change I see (aside from the added eieio-- prefixes) is that NAME is now
optional (but not obsolete), which is certainly a good thing.
> While reading through the patch, there was a bunch of changes related
> to doc strings and methods. The goal was if you used help on a
> method, such as:
>
> C-h f constructor RET
>
> (or eieio-constructor in your patch)
>
> it should list the core doc (generic) and doc for every class that has
> it's own implementation and custom doc. I couldn't intuit from the
> patch what might happen as some of the doc strings looked like they
> were removed?
I don't think that has changed. I just tried Emacs with the patch and I
see the "EIEIO-enhanced" docs as usual.
-David
next prev parent reply other threads:[~2015-01-02 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 17:59 Shrinking EIEIO objects Stefan Monnier
2015-01-02 2:40 ` Eric Ludlam
2015-01-02 11:22 ` David Engster [this message]
2015-01-02 15:04 ` Eric Ludlam
2015-01-02 15:34 ` David Engster
2015-01-03 2:11 ` Stefan Monnier
2015-01-03 9:55 ` David Engster
2015-01-04 19:34 ` Stefan Monnier
2015-01-09 5:44 ` Eric Abrahamsen
2015-01-09 15:11 ` Stefan Monnier
2015-01-10 2:03 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h9w9whp2.fsf@engster.org \
--to=deng@randomsample.de \
--cc=emacs-devel@gnu.org \
--cc=eric@siege-engine.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.