From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Date: Fri, 20 Feb 2015 18:56:30 +0000 Message-ID: <87h9ug4dk1.fsf@violet.siamics.net> References: <87pp953q1j.fsf_-_@violet.siamics.net> <83lhjslwup.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1424458646 11934 80.91.229.3 (20 Feb 2015 18:57:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2015 18:57:26 +0000 (UTC) To: 19903@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 19:57:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YOslD-0002Y2-FD for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 19:57:11 +0100 Original-Received: from localhost ([::1]:33788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOslC-0006ca-QC for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2015 13:57:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOsl9-0006bL-1L for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 13:57:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOsl5-0008LT-RG for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 13:57:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOsl4-0008LG-Kp for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 13:57:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YOsl4-0003jB-8d for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2015 13:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Feb 2015 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19903 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19903-submit@debbugs.gnu.org id=B19903.142445860114303 (code B ref 19903); Fri, 20 Feb 2015 18:57:02 +0000 Original-Received: (at 19903) by debbugs.gnu.org; 20 Feb 2015 18:56:41 +0000 Original-Received: from localhost ([127.0.0.1]:49696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOskj-0003id-8G for submit@debbugs.gnu.org; Fri, 20 Feb 2015 13:56:41 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:44987) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YOskh-0003iU-0d for 19903@debbugs.gnu.org; Fri, 20 Feb 2015 13:56:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=4/GTaQhJEMRzGwpVr+LVEpuLp37FRqbwJwca3zJpN+I=; b=fbKSS+ngKlcMv+R34KAUGj+GhhtDA//YcDvH4J2oF6V42HKbcQJC0cr/4ECaJd06gIagmcyoYLJ1sIq+47MURVxEbEWhlvcY3Ptldp65LTnt7o3Ow5WVxhALUUkOHHEn6QRyM95Eub0h02T6yugCzs/ey7A2hj5ctKsSLXOqEAQ=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YOskg-0001QE-8J for 19903@debbugs.gnu.org; Fri, 20 Feb 2015 18:56:38 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1YOskY-0001vC-Mt for 19903@debbugs.gnu.org; Sat, 21 Feb 2015 01:56:30 +0700 Mail-Followup-To: 19903@debbugs.gnu.org In-Reply-To: (Stefan Monnier's message of "Fri, 20 Feb 2015 12:18:38 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99659 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> Stefan Monnier writes: >> If string faces are rendered just the same as symbol ones, > I think that's a misfeature. I=E2=80=99m not familiar with the Emacs display code, so I have no opinion on this. >> I=E2=80=99d rather wonder if either facemenu-add-face should silently >> =E2=80=98intern=E2=80=99 all the strings it gets before use, /or/ face-= attribute >> should do that. (Or perhaps both.) > I think interning would be good, indeed, tho I would prefer if it > emitted some kind of warning instead of doing it silently, to try and > stop this bad habit. Please consider the patch MIMEd. --=20 FSF associate member #7257 np. Night Prowler =E2=80=94 AC/DC =E2=80=A6 3= 013 B6A0 230E 334A --=-=-= Content-Type: text/diff Content-Disposition: inline --- a/lisp/facemenu.el +++ b/lisp/facemenu.el @@ -702,6 +702,9 @@ defun facemenu-add-face (face &optional start end) text property. Otherwise, selecting the default face would not have any effect. See `facemenu-remove-face-function'." (interactive "*xFace: \nr") + (when (stringp face) + (warn "Face %S is a string; interning" face) + (setq face (intern face))) (cond ((and (eq face 'default) (not (eq facemenu-remove-face-function t))) --- a/lisp/faces.el +++ b/lisp/faces.el @@ -402,6 +402,9 @@ defun face-attribute (face attribute &optional frame inherit) value of `default' for INHERIT; this will resolve any unspecified or relative values by merging with the `default' face (which is always completely specified)." + (when (stringp face) + (message "Face %S is a string; interning" face) + (setq face (intern face))) (let ((value (internal-get-lisp-face-attribute face attribute frame))) (when (and inherit (face-attribute-relative-p attribute value)) ;; VALUE is relative, so merge with inherited faces --=-=-=--