From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#20149: Cannot byte-compile 'undo-tree' since commit 801eda8a2 Date: Fri, 20 Mar 2015 12:06:53 +0100 Message-ID: <87h9tgrkqa.fsf@gnu.org> References: <20150320051529.GC857@smoon.vl-lomov.ru> <87pp84ru05.fsf@gnu.org> <20150320081645.GD857@smoon.vl-lomov.ru> <87lhisrqrd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426849660 1271 80.91.229.3 (20 Mar 2015 11:07:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 11:07:40 +0000 (UTC) Cc: 20149@debbugs.gnu.org To: Vladimir Lomov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 20 12:07:20 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYull-0000nG-58 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 12:07:13 +0100 Original-Received: from localhost ([::1]:43215 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYulk-0001pY-7R for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 07:07:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYulg-0001pQ-6J for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 07:07:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYula-0004ST-SN for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 07:07:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYula-0004SP-OQ for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 07:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YYula-0001Cf-HZ for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 07:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20149 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20149-submit@debbugs.gnu.org id=B20149.14268496204617 (code B ref 20149); Fri, 20 Mar 2015 11:07:02 +0000 Original-Received: (at 20149) by debbugs.gnu.org; 20 Mar 2015 11:07:00 +0000 Original-Received: from localhost ([127.0.0.1]:58844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYulX-0001CO-Qh for submit@debbugs.gnu.org; Fri, 20 Mar 2015 07:07:00 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54850) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYulV-0001CG-CK for 20149@debbugs.gnu.org; Fri, 20 Mar 2015 07:06:58 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EE0FD209B8 for <20149@debbugs.gnu.org>; Fri, 20 Mar 2015 07:06:54 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 20 Mar 2015 07:06:57 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:from:to:cc:subject:references :date:in-reply-to:message-id:mime-version:content-type; s= smtpout; bh=GplmLueU/zZ3XVtHdSM79HVLSY4=; b=CSNQMNvSztoKQHQfxMAJ 9QRWbUkpsOykJdcpV63lBvrcmbrKe0LI5WJH1trCB6lXzusqyMOv16kn2enSvhlP XXz24Tet4ISqkCFSOC/VUGxQaxosuRty/G6ndjtOR3qIavimYmXTQqeJ3v+5ukJL jMZkX+hyKtos/79e4i12U5s= X-Sasl-enc: rd1cMHfGZTqf/SRz0iLD/nuYaixc4v4pneaj/S6D7TOd 1426849616 Original-Received: from thinkpad-t440p (unknown [2.161.210.144]) by mail.messagingengine.com (Postfix) with ESMTPA id 1BB03C00025; Fri, 20 Mar 2015 07:06:55 -0400 (EDT) In-Reply-To: <87lhisrqrd.fsf@gnu.org> (Tassilo Horn's message of "Fri, 20 Mar 2015 09:56:38 +0100") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100690 Archived-At: Tassilo Horn writes: > Vladimir Lomov writes: > >> In undo-tree-update-menu-bar: >> undo-tree.el:1232:7:Warning: reference to free variable `undo-tree-mode' >> undo-tree.el:1481:1:Error: Symbol's function definition is void: undo-tree-make-node >> >> I tracked down to the commit when Emacs was able to compile the >> 'undo-tree' package, this is commit f925fc93 but starting from next >> commit, 801eda8a2, the package isn't byte-compiled. Actually, I wasn't >> able to compile Emacs taking source from commit 801eda8a2 and next three >> ones. >> >>> Could you please verify that compiling undo-tree works again with the >>> current emacs git version? If so, feel free to close this bug by >>> replying to 20149-done@debbugs.gnu.org. >> >> I did fresh Emacs build (commit 395a76a) and I see the same message when >> byte-compile 'undo-tree' package. > > Ok, I see, and I confirm the compile error. `undo-tree-make-node' is an > undo-tree-node constructor. So it seems to be another problem with > Stefan's latest cl-defstruct changes. I've added him to Cc. Ups, of course I didn't. ;-) So now he is. > undo-tree is here: http://www.dr-qubit.org/git/undo-tree.git > > The definition of the constructor is this: > > (defstruct > (undo-tree-node > (:type vector) ; create unnamed struct > (:constructor nil) > (:constructor undo-tree-make-node > (previous undo > &optional redo > &aux > (timestamp (current-time)) > (branch 0))) > (:constructor undo-tree-make-node-backwards > (next-node undo > &optional redo > &aux > (next (list next-node)) > (timestamp (current-time)) > (branch 0))) > (:copier nil)) > previous next undo redo timestamp branch meta-data) > > > The error location (which looks strange to me) is this: > > (defun undo-tree-register-data-p (data) ;; <== HERE > (and (vectorp data) > (= (length data) 2) > (undo-tree-node-p (undo-tree-register-data-node data)))) > > Bye, > Tassilo