From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Uwe Brauer Newsgroups: gmane.emacs.devel Subject: Re: patch against vc-rcs.el: vc-rcs-checkin: allows user login to be added Date: Mon, 07 Sep 2015 20:46:49 +0000 Message-ID: <87h9n6ufd2.fsf@mat.ucm.es> References: <87d1xvv0m1.fsf@mat.ucm.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441659040 2180 80.91.229.3 (7 Sep 2015 20:50:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Sep 2015 20:50:40 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 07 22:50:28 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZZ3Mu-0006nP-JS for ged-emacs-devel@m.gmane.org; Mon, 07 Sep 2015 22:50:24 +0200 Original-Received: from localhost ([::1]:58728 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ3Mu-0002Nz-An for ged-emacs-devel@m.gmane.org; Mon, 07 Sep 2015 16:50:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ3Mr-0002Nu-Ez for emacs-devel@gnu.org; Mon, 07 Sep 2015 16:50:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZ3Mm-0005PD-Gw for emacs-devel@gnu.org; Mon, 07 Sep 2015 16:50:21 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:57302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZ3Mm-0005P5-9x for emacs-devel@gnu.org; Mon, 07 Sep 2015 16:50:16 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZZ3Ma-0006Oj-9F for emacs-devel@gnu.org; Mon, 07 Sep 2015 22:50:04 +0200 Original-Received: from 171.pool85-55-19.dynamic.orange.es ([85.55.19.171]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 07 Sep 2015 22:50:04 +0200 Original-Received: from oub by 171.pool85-55-19.dynamic.orange.es with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 07 Sep 2015 22:50:04 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 40 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 171.pool85-55-19.dynamic.orange.es Mail-Copies-To: never User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:H9JekJyYxUxBgYdJf+AY8iMaqkU= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189676 Archived-At: >>>>> "Stefan" == Stefan Monnier writes: >> +(defvar vc-rcs-ask-for-login nil >> + "*Variable which allows to change the login Id by >> a y-or-n question.") > How 'bout instead making vc-rcs.el use the "Author:" header in the > commit message, instead of adding a config var plus a prompt? > Try > grep "\"Author" lisp/vc/vc*.el Sorry but your grep command returns an error :'( In any case I presume you mean functions like this (defun vc-hg-checkin (files comment) "Hg-specific version of `vc-backend-checkin'. REV is ignored." (apply 'vc-hg-command nil 0 files (nconc (list "commit" "-m") (log-edit-extract-headers '(("Author" . "--user") ("Date" . "--date")) comment)))) So it is log-edit-extract-headers I will play around a bit not sure that will work easily. Thanks. > to see how other backends do it. > Stefan