From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Tue, 03 Nov 2015 01:22:03 +0200 Organization: LINKOV.NET Message-ID: <87h9l46l7o.fsf@mail.linkov.net> References: <20151029232302.GB3812@acm.fritz.box> <87h9l6627a.fsf@mail.linkov.net> <20151031235651.GE1853@acm.fritz.box> <87bnbddzpk.fsf@mail.linkov.net> <20151102092853.GA11804@acm.fritz.box> <20151102123512.GB11804@acm.fritz.box> <20151102154445.GD11804@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446506598 14158 80.91.229.3 (2 Nov 2015 23:23:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Nov 2015 23:23:18 +0000 (UTC) Cc: 17453@debbugs.gnu.org, Artur Malabarba , emacs-devel To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 03 00:23:09 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZtORQ-0002bJ-NG for ged-emacs-devel@m.gmane.org; Tue, 03 Nov 2015 00:23:08 +0100 Original-Received: from localhost ([::1]:44713 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtORP-0003lq-Ui for ged-emacs-devel@m.gmane.org; Mon, 02 Nov 2015 18:23:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtORM-0003lZ-Cc for emacs-devel@gnu.org; Mon, 02 Nov 2015 18:23:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtORI-0002bt-Ej for emacs-devel@gnu.org; Mon, 02 Nov 2015 18:23:04 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:49664 helo=homiemail-a23.g.dreamhost.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtORI-0002bp-96 for emacs-devel@gnu.org; Mon, 02 Nov 2015 18:23:00 -0500 Original-Received: from homiemail-a23.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTP id C0CBF4B006D; Mon, 2 Nov 2015 15:22:58 -0800 (PST) Original-Received: from localhost.linkov.net (62.65.227.66.cable.starman.ee [62.65.227.66]) (Authenticated sender: jurta@jurta.org) by homiemail-a23.g.dreamhost.com (Postfix) with ESMTPA id 957C44B0063; Mon, 2 Nov 2015 15:22:57 -0800 (PST) In-Reply-To: <20151102154445.GD11804@acm.fritz.box> (Alan Mackenzie's message of "Mon, 2 Nov 2015 15:44:45 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 69.163.253.7 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193123 Archived-At: > So how about us just moving all these checks to where they really > belong, in isearch-lazy-highlight-update? I've a feeling that if we do > this, then your function follow--search-function becomes unneeded. > > Juri? Right, without (sit-for 0) it's possible to switch focus to adjacent windows with just adding 2 lines to follow.el, i.e. I get the desired behavior with: diff --git a/lisp/follow.el b/lisp/follow.el index 938c59e..0433854 100644 --- a/lisp/follow.el +++ b/lisp/follow.el @@ -420,6 +420,7 @@ (define-minor-mode follow-mode (if follow-mode (progn (add-hook 'compilation-filter-hook 'follow-align-compilation-windows t t) + (add-hook 'isearch-update-post-hook 'follow-align-compilation-windows t t) (add-hook 'post-command-hook 'follow-post-command-hook t) (add-hook 'window-size-change-functions 'follow-window-size-change t)) ;; Remove globally-installed hook functions only if there is no @@ -432,6 +433,7 @@ (define-minor-mode follow-mode (unless following (remove-hook 'post-command-hook 'follow-post-command-hook) (remove-hook 'window-size-change-functions 'follow-window-size-change))) + (remove-hook 'isearch-update-post-hook 'follow-align-compilation-windows t) (remove-hook 'compilation-filter-hook 'follow-align-compilation-windows t))) (defun follow-find-file-hook () diff --git a/lisp/isearch.el b/lisp/isearch.el index b762884..8edf8b0 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -3018,7 +3018,7 @@ (defun isearch-lazy-highlight-new-loop (&optional beg end) search string to change or the window to scroll). It is also used by other Emacs features." (when (and (null executing-kbd-macro) - (sit-for 0) ;make sure (window-start) is credible + ; (sit-for 0) ;make sure (window-start) is credible (or (not (equal isearch-string isearch-lazy-highlight-last-string)) (not (eq (selected-window) So what remains to do is to fix this bug, but I don't understand the logic you proposed: how checks could be moved to isearch-lazy-highlight-update if isearch-lazy-highlight-update is scheduled by a timer conditionally depending on these checks?